Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTENT] Consul nameresolution component #1408

Closed
a-elsheikh opened this issue Apr 13, 2021 · 3 comments · Fixed by #1443
Closed

[CONTENT] Consul nameresolution component #1408

a-elsheikh opened this issue Apr 13, 2021 · 3 comments · Fixed by #1443
Assignees
@a-elsheikh
Labels
content/missing-information More information requested or needed
Milestone
v1.2

Comments

@a-elsheikh
Copy link
Contributor

a-elsheikh commented Apr 13, 2021 •
edited
Loading

What content needs to be created or modified?
We need a new section covering the consul name resolution component

Where should the new material be placed?
I imagine there'll need to be a new area for nameresolution components under: https://docs.dapr.io/reference/components-reference/

and then within that a section for the consul spec

Additional context
The information should reflect that which is in dapr/components-contrib/nameresolution/consul/Readme.md

PR - #1443
@a-elsheikh a-elsheikh added the content/missing-information More information requested or needed label Apr 13, 2021
@a-elsheikh a-elsheikh mentioned this issue Apr 13, 2021
Merged
3 tasks
@a-elsheikh a-elsheikh mentioned this issue Apr 22, 2021
Merged
7 tasks
@yaron2 yaron2 added this to the v1.2 milestone Apr 22, 2021
@yaron2
Copy link
Member

yaron2 commented Apr 22, 2021

/cc @AaronCrawfis

@yaron2
Copy link
Member

yaron2 commented Apr 22, 2021

@a-elsheikh the main PR in dapr/dapr is merged, please continue with the PR for docs. Thanks!

@a-elsheikh a-elsheikh mentioned this issue Apr 23, 2021
Merged
@CodeMonkeyLeet
Copy link
Contributor

@AaronCrawfis @msfussell Looks like this can be closed given the merge of #1443.

@AaronCrawfis AaronCrawfis linked a pull request May 21, 2021 that will close this issue
Consul name resolution docs #1443
Merged
@CodeMonkeyLeet CodeMonkeyLeet mentioned this issue Jul 1, 2021
Closed
4 tasks
pkedy added a commit to pkedy/docs that referenced this issue Jan 5, 2022
@pkedy
Docs tweak for dapr#1408 / dapr#1409: Kafka PubSub using metadata as …
c0593fe 
…headers
pkedy added a commit to pkedy/docs that referenced this issue Jan 5, 2022
@pkedy
Docs tweak for dapr#1408 / dapr#1409: Kafka PubSub using metadata as …
6079c0e 
…headers

Signed-off-by: Phil Kedy <phil.kedy@gmail.com>
greenie-msft added a commit that referenced this issue Jan 21, 2022
@greenie-msft
Merge pull request #2083 from pkedy/kafka_pubsub_metadata_as_headers_…
0f938b5 
…1408

Docs tweak for #1408 / #1409: Kafka PubSub using metadata as headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-elsheikh a-elsheikh

Labels
content/missing-information More information requested or needed
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Consul name resolution docs
4 participants
@yaron2 @CodeMonkeyLeet @AaronCrawfis @a-elsheikh