add pubsub redis config docs #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@Taction Please create a docs issue and link this PR to that ... |
pkedy
reviewed
Mar 25, 2021
There was a problem hiding this comment.
The new settings are all capture. Great job!
Made some wording tweaks / suggestions but @orizohar is probably better at that :)
Also, I think dapr/components-contrib#763 needs to be merged before this can be.
daprdocs/content/en/operations/components/setup-pubsub/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/components/setup-pubsub/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/components/setup-pubsub/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/components/setup-pubsub/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/components/setup-pubsub/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/operations/components/setup-pubsub/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
|
@Taction - since the relevant feature is going in v1.2 (not the upcoming v1.1) I rebased the PR so it is merged to the v1.2 docs branch |
|
Stale PR, paging all reviewers |
AaronCrawfis
added
the
requested-change
AaronCrawfis
approved these changes
Apr 9, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
add some config that can be set from metadata for redis client.
Issue reference
#1339