Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MongoDB state store component documentation #1571

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Update MongoDB state store component documentation #1571

merged 1 commit into from
Jun 18, 2021

Conversation

dmitsh
Copy link
Contributor

@dmitsh dmitsh commented Jun 16, 2021

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Update MongoDB state store component documentation

Issue reference

#1568

@dmitsh dmitsh requested a review from a team as a code owner June 16, 2021 20:48
@dmitsh dmitsh mentioned this pull request Jun 16, 2021
Closed
6 tasks
halspang
halspang reviewed Jun 17, 2021
View reviewed changes
Copy link
Contributor

@halspang halspang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me, just a formatting question.

daprdocs/content/en/reference/components-reference/supported-state-stores/setup-mongodb.md Outdated Show resolved Hide resolved
@dmitsh dmitsh requested a review from halspang June 18, 2021 01:10
halspang
halspang approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@halspang halspang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The external link validator appears to have failed but I can open the link so maybe just rerun it?

@AaronCrawfis AaronCrawfis merged commit ac276fc into dapr:v1.3 Jun 18, 2021
@dmitsh dmitsh deleted the ds-mongodb-doc branch June 18, 2021 19:10
@dmitsh dmitsh mentioned this pull request Jun 24, 2021
Closed
4 tasks
sk593 pushed a commit to sk593/docs that referenced this pull request Jul 20, 2021
@dmitsh @sk593
Update MongoDB state store component documentation (dapr#1571)
b001fff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artursouza artursouza artursouza approved these changes

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

@halspang halspang halspang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitsh @artursouza @AaronCrawfis @halspang