Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos described in https://github.com/dapr/docs/issues/1735 #1736

Merged
merged 2 commits into from
Aug 20, 2021
Merged

fix typos described in https://github.com/dapr/docs/issues/1735 #1736

merged 2 commits into from
Aug 20, 2021
+1 −1

Conversation

willtsai
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Fixed minor sentence typos in the pubsub-overview page

Issue reference

@willtsai willtsai requested a review from a team as a code owner August 20, 2021 19:28
@willtsai
Copy link
Contributor Author

Tested and validated locally:
image

orizohar
orizohar approved these changes Aug 20, 2021
View reviewed changes
Copy link

@orizohar orizohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orizohar orizohar merged commit b4157f7 into dapr:v1.3 Aug 20, 2021
@orizohar orizohar mentioned this pull request Aug 20, 2021
Closed
@willtsai willtsai mentioned this pull request Aug 26, 2021
Closed
4 tasks
@willtsai willtsai mentioned this pull request Nov 10, 2021
Closed
4 tasks
@willtsai willtsai deleted the willtsai-Minor_Typo_in_Publish_and_subscribe_overview_1735 branch November 12, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orizohar orizohar orizohar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willtsai @orizohar