Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving middleware to samples #2108

Merged
merged 2 commits into from
Jan 19, 2022
Merged

moving middleware to samples #2108

merged 2 commits into from
Jan 19, 2022

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jan 15, 2022

Signed-off-by: Paul Yuknewicz paulyuk@microsoft.com

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Middleware has been moved from Quickstarts to Samples. This is the corresponding doc changes.

Issue reference

Fixes dapr/quickstarts#512

Waiting on
dapr/quickstarts#513
dapr/samples#94

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jan 15, 2022
@paulyuk paulyuk requested review from a team as code owners January 15, 2022 00:01
@greenie-msft
Copy link
Collaborator

This validation error is expect and will resolve once the middleware example is moved into the samples repo

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@greenie-msft greenie-msft removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jan 19, 2022
@greenie-msft greenie-msft merged commit 77caed9 into dapr:v1.5 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: moving Middleware quickstart to Samples repo
2 participants