-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upmerge of v1.7 into v1.8 20220518 #2446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Fix CLI certificate renewal command typo Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Fix CLI command typo
* Update state-store-ttl.md Add comma so the metadata value is a tuple of tuple, otherwise Python collapses it to just being an ordinary tuple. Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> * Update pubsub-raw.md Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
* fix go quickstart port Signed-off-by: yaron2 <schneider.yaron@live.com> * fix pub/sub port also Signed-off-by: yaron2 <schneider.yaron@live.com>
…r#2359) * Wrong working directory for .Net state management sample The working directory for .NET is pointing to `pub_sub` but it should be `state_management`. Signed-off-by: Stephane Lapointe <stephane.lap@outlook.com> * Removing the word "publisher" which was also unneed Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
…2372) * clarify transactional operations in docs Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * Added some more details for clarity * updates per Mark Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * remove en from link Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * ignore links attempt Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: moreyhat <moreyhat@gmail.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
`\` is missing for some curl examples. Signed-off-by: zhangchao <zchao9100@gmail.com>
[dapr init] add new flags and examples to docs
Fix curl example
[nats streaming pub/sub] fix parameter typo
[metrics] fix code snippet typo
Update dapr runtime version to 1.7.2
* extend dapr api example Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * remove extra # Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * quote urls Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * ignore links Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * remove transactional and bulk get Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * update intro to only one object Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * Update daprdocs/content/en/getting-started/get-started-api.md Co-authored-by: Mark Fussell <markfussell@gmail.com> * Update daprdocs/content/en/getting-started/get-started-api.md Co-authored-by: Mark Fussell <markfussell@gmail.com> * Update daprdocs/content/en/getting-started/get-started-api.md Co-authored-by: Mark Fussell <markfussell@gmail.com> * Update daprdocs/content/en/getting-started/get-started-api.md Co-authored-by: Mark Fussell <markfussell@gmail.com> * Update daprdocs/content/en/getting-started/get-started-api.md Co-authored-by: Mark Fussell <markfussell@gmail.com> * Update daprdocs/content/en/getting-started/get-started-api.md Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
The config sample yaml used the wrong namespace and while in there I decided to mention the name of the config instead of just its namespace since the two are so similar, I didn't want people to think one was a typo. And the monitoring sample had a typo. Signed-off-by: Doug Davis <dug@microsoft.com>
* fix typo in js command Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * check commands in other quickstarts Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
…ly go to (dapr#2400) Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
* add profile-port to env variables table Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * fix link Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
* error code fixes Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> * reverting changes to secrets api Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: msfussell <markfussell@gmail.com>
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: msfussell <markfussell@gmail.com> Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
- JS and curl samples were sending data as objects but sample apps expected ints - Improved JS sample to correctly handle async code and make it more readable - Fixed indentation in .NET code - JavaScript has uppercased S Signed-off-by: Alessandro Segala (ItalyPaleAle) <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
* API tokens do not need to be JWT's Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> * Updated app-api-token Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
* message for restarting the dapr-enabled pods Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Addressed review comments Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: zhangchao <zchao9100@gmail.com>
Signed-off-by: fabistb <fabian0401@online.de>
Signed-off-by: msfussell <markfussell@gmail.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
Signed-off-by: Jack Liu shurui <jackliusr@gmail.com>
Update runtime version to 1.7.3
correct configurations.program in launch.json
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
msfussell
approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upmerge of v1.7 into v1.8 20220518