-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidirectional Subscriptions #578
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 58.04% 62.05% +4.00%
==========================================
Files 55 53 -2
Lines 3568 3352 -216
==========================================
+ Hits 2071 2080 +9
+ Misses 1375 1151 -224
+ Partials 122 121 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Adds support for bidirectional subscriptions to PubSubs. Adds two methods for subscribing- one using a callback and one using an imperative approach. Both giving support to different programming styles or use cases. Adds example with tests. Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: Mike Nguyen <hey@mike.ee>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
the validation step is failing |
It fails as the validation is running the latest version of Dapr rather than the RC. I've validated with RC2 and it's smooth as butter 🙂 we could set the validation workflow to 1.14.0-rc.2 on the release branch if that helps push this through. |
Can't argue with "smooth as butter" :) |
@holopin-bot @JoshVanL Thanks Josh! |
Congratulations @JoshVanL, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvb8tyf10350cmgajs8h4lq This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Adds support for bidirectional subscriptions to PubSubs. Adds two methods for subscribing- one using a callback and one using an imperative approach. Both giving support to different programming styles or use cases.
Adds example with tests.
Requires daprd built from dapr/dapr#7770