Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types/http): use import * as http(s) #308

Merged
merged 1 commit into from Jul 20, 2022

Conversation

webup
Copy link
Contributor

@webup webup commented Jun 26, 2022

Fixes "Module '"http"' has no default export" #307

Signed-off-by: Haili Zhang haili.zhang@outlook.com

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #307

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Fixes "Module '"http"' has no default export" dapr#307

Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @webup!

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #308 (155d6bb) into master (5f6fd57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   31.34%   31.34%           
=======================================
  Files          81       81           
  Lines        5896     5896           
  Branches      199      199           
=======================================
  Hits         1848     1848           
  Misses       4008     4008           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6fd57...155d6bb. Read the comment docs.

@shubham1172
Copy link
Member

ping @XavierGeerinck

@XavierGeerinck XavierGeerinck merged commit a941c3d into dapr:master Jul 20, 2022
@XavierGeerinck
Copy link
Contributor

Thanks for contributing! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module '"http"' has no default export
4 participants