Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Add workflow management HTTP APIs #485

Merged
merged 15 commits into from Jun 8, 2023

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented May 2, 2023

Description

This PR adds the HTTP APIs for managing workflows. Documentation: https://v1-11.docs.dapr.io/reference/api/workflow_api/

Writing E2E tests will require workflow authoring capabilities as well, this will be done as part of next release once WF authoring is supported - tracking issue: #498

Issue reference

Please reference the issue this PR will close: #463

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@dapr-bot
Copy link
Collaborator

dapr-bot commented Jun 2, 2023

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Jun 2, 2023
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 changed the title [WIP] feat(workflow): Add workflow management APIs [WIP] feat(workflow): Add workflow management HTTP APIs Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #485 (39b5536) into main (af71496) will decrease coverage by 0.14%.
The diff coverage is 39.80%.

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   35.84%   35.70%   -0.14%     
==========================================
  Files          85       87       +2     
  Lines       10047    10122      +75     
  Branches      394      412      +18     
==========================================
+ Hits         3601     3614      +13     
- Misses       6387     6449      +62     
  Partials       59       59              
Impacted Files Coverage Δ
src/implementation/Client/HTTPClient/workflow.ts 11.29% <11.29%> (ø)
src/implementation/Client/GRPCClient/workflow.ts 22.22% <22.22%> (ø)
src/implementation/Client/DaprClient.ts 84.94% <100.00%> (+0.67%) ⬆️

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 changed the title [WIP] feat(workflow): Add workflow management HTTP APIs feat(workflow): Add workflow management HTTP APIs Jun 8, 2023
@shubham1172 shubham1172 marked this pull request as ready for review June 8, 2023 05:36
@shubham1172 shubham1172 requested review from a team as code owners June 8, 2023 05:36
src/implementation/Client/HTTPClient/workflow.ts Outdated Show resolved Hide resolved
src/implementation/Client/HTTPClient/workflow.ts Outdated Show resolved Hide resolved
src/implementation/Client/HTTPClient/workflow.ts Outdated Show resolved Hide resolved
src/implementation/Client/HTTPClient/workflow.ts Outdated Show resolved Hide resolved
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@XavierGeerinck XavierGeerinck added this pull request to the merge queue Jun 8, 2023
Merged via the queue into dapr:main with commit 5e42a79 Jun 8, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow implementation in SDK
3 participants