chore(config): updating config API to use v1 endpoint #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 36.72% 36.14% -0.59%
==========================================
Files 82 82
Lines 9927 9927
Branches 371 371
==========================================
- Hits 3646 3588 -58
- Misses 6222 6280 +58
Partials 59 59
|
shubham1172
previously approved these changes
May 30, 2023
|
Hi @shivamkm07, could you please check the e2e test, looks like it's failing 
(It still reports passing due to some weird bug). |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
shivamkm07
force-pushed
the
update_configurationAPI
branch
from
55df5d4
to
715690b
Compare
|
Awesome |
shubham1172
approved these changes
May 30, 2023
jriffs
pushed a commit
to jriffs/js-sdk
that referenced
this pull request
Jun 7, 2023
* updating config API to use v1 endpoint Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * using latest runtime rc Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> --------- Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: jriffs <mayjriffs97@gmail.com>
shubham1172
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates configuration API implementation to use the v1 stable endpoint instead of alpha1 endpoint.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: