Workflow authoring support #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more updates update durabletask-js version init workflow support Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
kaibocai
force-pushed
the
kaibocai/workflow
branch
from
7328d00
to
3a2649f
Compare
shubham1172
requested changes
Jan 5, 2024
improve workflow unit test Signed-off-by: kaibocai <kaibocai@microsoft.com>
kaibocai
force-pushed
the
kaibocai/workflow
branch
from
3989514
to
781a620
Compare
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
DeepanshuA
reviewed
Jan 9, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
===========================================
+ Coverage 35.36% 55.79% +20.43%
===========================================
Files 95 14 -81
Lines 10570 319 -10251
Branches 452 63 -389
===========================================
- Hits 3738 178 -3560
+ Misses 6745 124 -6621
+ Partials 87 17 -70 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kaibocai <kaibocai@microsoft.com>
kaibocai
force-pushed
the
kaibocai/workflow
branch
from
0b0d5c4
to
378dfe2
Compare
DeepanshuA
reviewed
Jan 10, 2024
Signed-off-by: kaibocai <kaibocai@microsoft.com>
shubham1172
requested changes
Jan 11, 2024
Signed-off-by: kaibocai <kaibocai@microsoft.com>
shubham1172
changed the title
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
shubham1172
reviewed
Jan 15, 2024
Signed-off-by: kaibocai <kaibocai@microsoft.com>
shubham1172
reviewed
Jan 15, 2024
Signed-off-by: kaibocai <kaibocai@microsoft.com>
shubham1172
reviewed
Jan 16, 2024
shubham1172
reviewed
Jan 16, 2024
Signed-off-by: kaibocai <kaibocai@microsoft.com>
shubham1172
previously approved these changes
Jan 16, 2024
There was a problem hiding this comment.
LGTM, thanks for the PR and great work @kaibocai! This will greatly benefit JS SDK users who have been wanting to try out authoring Dapr Workflow!
DeepanshuA
reviewed
Jan 19, 2024
Signed-off-by: kaibocai <kaibocai@microsoft.com>
DeepanshuA
approved these changes
Jan 22, 2024
shubham1172
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR initiates the support for dapr workflow.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #463 and #545
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
cc @cgillum, @rabollin, @torosent