Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support null etag #169

Closed
artursouza opened this issue Jan 14, 2021 · 0 comments · Fixed by #171
Closed

Support null etag #169

artursouza opened this issue Jan 14, 2021 · 0 comments · Fixed by #171
Assignees
@wcs1only
Labels
kind/bug Something isn't working P1

Comments

@artursouza
Copy link
Member

Expected Behavior

Comply with new proto for etag as per https://github.com/dapr/dapr/pull/2666/files

Actual Behavior

eTag is still handled as a simple string.

Steps to Reproduce the Problem

Use master version of daprd and use any API that uses etag.

Release Note

RELEASE NOTE: FIXED Support for null and empty etag.
@artursouza artursouza added the kind/bug Something isn't working label Jan 14, 2021
@artursouza artursouza added the P1 label Jan 14, 2021
@artursouza artursouza self-assigned this Jan 20, 2021
@artursouza artursouza assigned wcs1only and unassigned artursouza Jan 21, 2021
wcs1only added a commit to wcs1only/python-sdk that referenced this issue Jan 23, 2021
@wcs1only
Make state store etag nullalble (dapr#169)
92d6bce
@wcs1only wcs1only mentioned this issue Jan 23, 2021
Merged
3 tasks
wcs1only added a commit to wcs1only/python-sdk that referenced this issue Jan 23, 2021
@wcs1only
Make state store etag nullalble (dapr#169)
f8f1cf9
wcs1only added a commit to wcs1only/python-sdk that referenced this issue Jan 23, 2021
@wcs1only
Make state store etag nullalble (dapr#169)
243288a
wcs1only added a commit to wcs1only/python-sdk that referenced this issue Jan 23, 2021
@wcs1only
Make state store etag nullalble (dapr#169)
f4355c8
artursouza pushed a commit that referenced this issue Jan 23, 2021
@wcs1only
Update etag to use protobuf definition. (#171)
990f228 
* Update grpc definitions

* Make state store etag nullalble (#169)
@artursouza artursouza mentioned this issue Jan 23, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wcs1only wcs1only

Labels
kind/bug Something isn't working P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update etag to use protobuf definition. wcs1only/python-sdk
2 participants
@artursouza @wcs1only