Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Security upgrade aiohttp from 3.8.6 to 3.9.4 #708

Closed
wants to merge 1 commit into from
Closed

[Snyk] Security upgrade aiohttp from 3.8.6 to 3.9.4 #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/workflow/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
dapr-ext-workflow>=0.1.0
aiohttp>=3.9.4 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead we should pin a higher minimum version of dapr-ext-workflow which itself should bring a newer version of the core dapr Pyhthon SDK. aiohttp is introduced via the core dapr SDK. That's where we should be updating it and release a new version if necessary.

Could you please do that instead? I'm not a fan of overloading it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also sign your commits please

Loading