Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new optional section for VS Code specific debugging #461

Merged
merged 8 commits into from Oct 6, 2021

Conversation

jasonviviano
Copy link
Contributor

Description

Have added new steps to show users how to use VSCode launch configurations for debugging and added changes to the .vscode folder to allow a clone and run experience with the hello-world project.

Issue reference

dapr/docs#1657

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary

@jasonviviano
Copy link
Contributor Author

Auto Validation failed since the current link added in the readme by me isn't available in the Dapr Docs yet. Its in this pull request: dapr/docs#1673

hello-world/README.md Outdated Show resolved Hide resolved
@wcs1only
Copy link
Contributor

wcs1only commented Jul 22, 2021

@orizohar should we have this as its own quickstart? Does this even belong in the quickstarts? We should probably be IDE agnostic in the quickstarts?

Love the content, just want to make sure this is the best place for it.

@orizohar
Copy link

@orizohar should we have this as its own quickstart? Does this even belong in the quickstarts? We should probably be IDE agnostic in the quickstarts?

Love the content, just want to make sure this is the best place for it.

I think it's okay as an optional section at the end of the quickstart especially since VS Code is a very popular IDE. I wouldn't make it its own quickstart. However, @jasonviviano if you are writing a whole page in the docs that runs through this we don't need the detailed steps here, we can just refer them there. I would point out the .vscode files are included in the quickstart and send users to the docs for details

@jasonviviano
Copy link
Contributor Author

@wcs1only @orizohar Let me know if the section change aligns more with your idea of keeping it agnostic. Also added the .vscode section I created for a plug and go experience for users. BTW i tested it on my Windows PC and everything works just like i did on my Mac however I ended up encountering a bug that's effecting the newest version of Mac's with M1 here microsoft/vscode#129214 incase any of you want to try it and have a Mac.

distributed-calculator/README.md Outdated Show resolved Hide resolved
distributed-calculator/README.md Show resolved Hide resolved
hello-world/README.md Outdated Show resolved Hide resolved
orizohar
orizohar previously approved these changes Jul 23, 2021
Copy link

@orizohar orizohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orizohar orizohar requested a review from wcs1only July 23, 2021 23:35
@wcs1only
Copy link
Contributor

wcs1only commented Aug 4, 2021

Are the .png files used anymore? They are still in the commit, but I don't see them referenced anywhere.

@jasonviviano
Copy link
Contributor Author

Are the .png files used anymore? They are still in the commit, but I don't see them referenced anywhere.

Yeah just deleted them they were left by mistake.

@orizohar orizohar merged commit 7d538e6 into dapr:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants