Skip to content

Added a How-To section for VSCode debugging#1673

Closed
jasonviviano wants to merge 23 commits intodapr:v1.2from
jasonviviano:jviviano
Closed

Added a How-To section for VSCode debugging#1673
jasonviviano wants to merge 23 commits intodapr:v1.2from
jasonviviano:jviviano

Conversation

@jasonviviano
Copy link
Copy Markdown
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • [ x] Read the contribution guide
  • [ x] Commands include options for Linux, MacOS, and Windows within codetabs
  • [ x] New file and folder names are globally unique
  • [ x] Page references use shortcodes instead of markdown or URL links
  • [ x] Images use HTML style and have alternative text
  • [ x] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added a section to explain the usage of VS Code configurations for multiple Dapr applications.

Issue reference

#1657

}
```

This is the full list of the parameters the Daprd tasks you need to create can use, not all are going to be necessary but for future customization its important to be aware.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a table for:

  • parameter
  • Description
  • Required
  • Example

Copy link
Copy Markdown
Contributor

@greenie-msft greenie-msft Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronCrawfis @orizohar @msfussell - We can add a new table here, or we can add a VS Code param column to this existing table and link to it: https://docs.dapr.io/reference/arguments-annotations-overview/

Thoughts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created the table but do need some suggestions on exactly what an example placementHostAddress, sentryAddress and controlPlaneAddress would represent left those empty

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronCrawfis @orizohar @msfussell - We can add a new table here, or we can add a VS Code param column to this existing table and link to it: https://docs.dapr.io/reference/arguments-annotations-overview/

Thoughts?

Aren't the VS Code params just daprd params? I think the daprd column should be enough

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are, but they are formatted slightly differently so it's not a copy paste solution.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created the table but do need some suggestions on exactly what an example placementHostAddress, sentryAddress and controlPlaneAddress would represent left those empty

I'm not sure these are relevant to self hosting mode. Most likely these should just be a local address. Need to confirm with @artursouza or @wcs1only

Copy link
Copy Markdown
Contributor Author

@jasonviviano jasonviviano Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, they're just localhost addresses. Have updated the table.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are localhost in case of local development.

jasonviviano and others added 11 commits July 22, 2021 13:18
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Mark Fussell <mfussell@microsoft.com>
…-how-to-debug-multiple-dapr-apps.md

Co-authored-by: Mark Fussell <mfussell@microsoft.com>
@msfussell msfussell added this to the v1.3 milestone Jul 22, 2021
@AaronCrawfis AaronCrawfis linked an issue Jul 23, 2021 that may be closed by this pull request
@orizohar
Copy link
Copy Markdown

I pushed a commit with some changes to style and tone

Copy link
Copy Markdown

@AaronCrawfis AaronCrawfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good! I have some suggestions though that I can't paste in the GitHub UI. Could you allow maintainers to push content to your branch?

https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@AaronCrawfis
Copy link
Copy Markdown

Actually it looks like you already did, will debug on my end

@AaronCrawfis
Copy link
Copy Markdown

See #1687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add How-To doc for VS Code extension debugging

6 participants