New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paulyuk/fixpubsuberror #547

Merged

msfussell merged 24 commits into master from paulyuk/fixpubsuberror

Feb 23, 2022

Contributor

paulyuk commented Feb 23, 2022

Description

Reduced the output precision in match to accomodate difference in kubernetes vs. standalone MM test.

Issue reference

Fixes #545
Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

The quickstart code compiles correctly
You've tested new builds of the quickstart if you changed quickstart code
You've updated the quickstart's README if necessary
If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

paulyuk and others added 24 commits

February 18, 2022 08:15


          Fixing error caused by route to * conflicing with /dapr/subscribe

0b6ef93

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Migrating from requests to axios to improve supportability

7e919c1

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Changed from " to ' matching existing styles for Javascript

7c88336

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Changing axios from import to require('axios'), matching require('e…

52acd06

…xpress')

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Merge branch 'master' into paulyuk/fixpubsuberror

895366d


          Consistent use of Async enabled http code

9963d09

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Migrated distributed calculator from request with pipe to axios w…

…ith service invoke.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Fixed react * route bug that conflicts with /dapr/subscribe route

3aec865

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Reducing log levels introduced by migration. added debug flag.

a0263b8

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Updating MM test to match improved precision of Express server.js wit…

0d6ee64

…h Axios.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          updating console.log from console.debug (minor) for consistency.

54202d2

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Updated vars to const, and then updated README to match.

7657fcd

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per …

78531cb

…@shubham1172 review.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Async posts needed await. Readme's tweaked to match updates.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>


          Update pub-sub/README.md

bf17a2e

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>


          Async should pair with await

04b8a5c

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Fixing comment

322760f

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Merge branch 'paulyuk/fixpubsuberror' of https://github.com/dapr/quic…

2a2977a

…kstarts into paulyuk/fixpubsuberror


          Removing commented out pipe

a5dadaf

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Per @XavierGeerinck review updated JS styles: return, casting, inlini…

ae22a28

…ng URLs, and removing console.log

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Per @XavierGeerinck review migrated from BodyParser.json() middleware…

d4d3e5b

… to Express.json() built in. Updated dependencies

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Hotfix to test, given precision sensitivity on test output number

fcffa84

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>


          Merge branch 'master' into paulyuk/fixpubsuberror

3882e4a

msfussell approved these changes

View reviewed changes

Member

msfussell left a comment

LGTM

msfussell merged commit f80fe76 into master

msfussell pushed a commit that referenced this pull request


           Merge updates from master into feature/new_quickstarts (#573)

* Bump follow-redirects in /distributed-calculator/react-calculator/client (#530)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects in /pub-sub/react-form/client (#531)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* Refresh pub-sub quickstart (tutorial) fixing routes and stale dependency (#539)

* Fixing error caused by route to * conflicing with /dapr/subscribe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrating from `requests` to `axios` to improve supportability

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changed from " to ' matching existing styles for Javascript

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changing `axios` from import to require('axios'), matching require('express')

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Consistent use of Async enabled http code

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrated distributed calculator from `request` with pipe to `axios` with service invoke.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixed react * route bug that conflicts with /dapr/subscribe route

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Reducing log levels introduced by migration.  added debug flag.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating MM test to match improved precision of Express server.js with Axios.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* updating console.log from console.debug (minor) for consistency.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated vars to const, and then updated README to match.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per @shubham1172 review.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Async posts needed await.  Readme's tweaked to match updates.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Async should pair with await

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixing comment

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Removing commented out pipe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review updated JS styles: return, casting, inlining URLs, and removing console.log

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review migrated from BodyParser.json() middleware to Express.json() built in.  Updated dependencies

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Paulyuk/fixpubsuberror (#547)

* Fixing error caused by route to * conflicing with /dapr/subscribe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrating from `requests` to `axios` to improve supportability

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changed from " to ' matching existing styles for Javascript

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changing `axios` from import to require('axios'), matching require('express')

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Consistent use of Async enabled http code

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrated distributed calculator from `request` with pipe to `axios` with service invoke.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixed react * route bug that conflicts with /dapr/subscribe route

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Reducing log levels introduced by migration.  added debug flag.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating MM test to match improved precision of Express server.js with Axios.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* updating console.log from console.debug (minor) for consistency.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated vars to const, and then updated README to match.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per @shubham1172 review.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Async posts needed await.  Readme's tweaked to match updates.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Async should pair with await

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixing comment

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Removing commented out pipe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review updated JS styles: return, casting, inlining URLs, and removing console.log

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review migrated from BodyParser.json() middleware to Express.json() built in.  Updated dependencies

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Hotfix to test, given precision sensitivity on test output number

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Improved MM test fix for quickstarts (#548)

* Fixing error caused by route to * conflicing with /dapr/subscribe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrating from `requests` to `axios` to improve supportability

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changed from " to ' matching existing styles for Javascript

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Changing `axios` from import to require('axios'), matching require('express')

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Consistent use of Async enabled http code

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Migrated distributed calculator from `request` with pipe to `axios` with service invoke.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixed react * route bug that conflicts with /dapr/subscribe route

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Reducing log levels introduced by migration.  added debug flag.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating MM test to match improved precision of Express server.js with Axios.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* updating console.log from console.debug (minor) for consistency.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated vars to const, and then updated README to match.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per @shubham1172 review.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Async posts needed await.  Readme's tweaked to match updates.

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Update pub-sub/README.md

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Async should pair with await

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixing comment

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Removing commented out pipe

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review updated JS styles: return, casting, inlining URLs, and removing console.log

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Per @XavierGeerinck review migrated from BodyParser.json() middleware to Express.json() built in.  Updated dependencies

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Hotfix to test, given precision sensitivity on test output number

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Fixing all remaining decimal precision issues with MM tests in readmes, including observability which now fails

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>

* Fix curl sample to work on macOS (#543)

Signed-off-by: Marcin Jahn <marcinj10@gmail.com>

* Fix sample path in readme (#555)

Signed-off-by: Xin Shi <xshi@microsoft.com>

Co-authored-by: Mark Fussell <mfussell@microsoft.com>

* Remove PR check for docker login (#565)

* remove PR check for docker login

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* remove PR trigger for the workflow to fix docker login issue

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>

* Test validation cleanup (#569)

* Test validation cleanup

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* add one response message in each of the validation steps

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark Fussell <mfussell@microsoft.com>
Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Marcin Jahn <marcinj10@gmail.com>
Co-authored-by: Xin Shi <xshi@microsoft.com>
Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment