Remove PR check for docker login #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
artursouza
requested changes
Mar 1, 2022
I am not sure I understand the context. Why do we need to remove the trigger on PR creation for the workflow instead of removing the check that disables the login for PR creation. We don't want this workflow to be triggered at any PR creation? even in release branch? I have submitted the change but I am curious about this -Also adding this as first quick fix and I already have a PR for publishing images to GHCR but it might take revisions to get that all good and so wanted to unblock us first with this fix |
Signed-off-by: tanvigour <tanvi.gour@gmail.com>
artursouza
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
@tanvigour We need 2 things after this PR, please track in separate issues and assign to yourself:
- Publish the quickstart (tutorial) app images to GHCR.
- Change this build pipeline to login to GHCR and re-enable PR validation.
Please, track those as 2 separate issues in quickstart. We can start those right away.
msfussell
pushed a commit
that referenced
this pull request
Mar 4, 2022
* Bump follow-redirects in /distributed-calculator/react-calculator/client (#530) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump follow-redirects in /pub-sub/react-form/client (#531) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Fussell <mfussell@microsoft.com> * Refresh pub-sub quickstart (tutorial) fixing routes and stale dependency (#539) * Fixing error caused by route to * conflicing with /dapr/subscribe Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Migrating from `requests` to `axios` to improve supportability Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Changed from " to ' matching existing styles for Javascript Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Changing `axios` from import to require('axios'), matching require('express') Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Consistent use of Async enabled http code Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Migrated distributed calculator from `request` with pipe to `axios` with service invoke. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Fixed react * route bug that conflicts with /dapr/subscribe route Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Reducing log levels introduced by migration. added debug flag. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updating MM test to match improved precision of Express server.js with Axios. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * updating console.log from console.debug (minor) for consistency. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated vars to const, and then updated README to match. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per @shubham1172 review. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Async posts needed await. Readme's tweaked to match updates. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Update pub-sub/README.md Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Update pub-sub/README.md Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Async should pair with await Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Fixing comment Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Removing commented out pipe Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Per @XavierGeerinck review updated JS styles: return, casting, inlining URLs, and removing console.log Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Per @XavierGeerinck review migrated from BodyParser.json() middleware to Express.json() built in. Updated dependencies Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Paulyuk/fixpubsuberror (#547) * Fixing error caused by route to * conflicing with /dapr/subscribe Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Migrating from `requests` to `axios` to improve supportability Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Changed from " to ' matching existing styles for Javascript Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Changing `axios` from import to require('axios'), matching require('express') Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Consistent use of Async enabled http code Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Migrated distributed calculator from `request` with pipe to `axios` with service invoke. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Fixed react * route bug that conflicts with /dapr/subscribe route Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Reducing log levels introduced by migration. added debug flag. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updating MM test to match improved precision of Express server.js with Axios. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * updating console.log from console.debug (minor) for consistency. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated vars to const, and then updated README to match. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per @shubham1172 review. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Async posts needed await. Readme's tweaked to match updates. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Update pub-sub/README.md Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Update pub-sub/README.md Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Async should pair with await Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Fixing comment Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Removing commented out pipe Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Per @XavierGeerinck review updated JS styles: return, casting, inlining URLs, and removing console.log Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Per @XavierGeerinck review migrated from BodyParser.json() middleware to Express.json() built in. Updated dependencies Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Hotfix to test, given precision sensitivity on test output number Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Improved MM test fix for quickstarts (#548) * Fixing error caused by route to * conflicing with /dapr/subscribe Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Migrating from `requests` to `axios` to improve supportability Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Changed from " to ' matching existing styles for Javascript Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Changing `axios` from import to require('axios'), matching require('express') Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Consistent use of Async enabled http code Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Migrated distributed calculator from `request` with pipe to `axios` with service invoke. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Fixed react * route bug that conflicts with /dapr/subscribe route Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Reducing log levels introduced by migration. added debug flag. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updating MM test to match improved precision of Express server.js with Axios. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * updating console.log from console.debug (minor) for consistency. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updated vars to const, and then updated README to match. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Updating Axios release(s) in Distributed Calc and pub-sub to v0.26 per @shubham1172 review. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Async posts needed await. Readme's tweaked to match updates. Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Update pub-sub/README.md Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Update pub-sub/README.md Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Async should pair with await Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Fixing comment Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Removing commented out pipe Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Per @XavierGeerinck review updated JS styles: return, casting, inlining URLs, and removing console.log Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Per @XavierGeerinck review migrated from BodyParser.json() middleware to Express.json() built in. Updated dependencies Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Hotfix to test, given precision sensitivity on test output number Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> * Fixing all remaining decimal precision issues with MM tests in readmes, including observability which now fails Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Shubham Sharma <shubhash@microsoft.com> * Fix curl sample to work on macOS (#543) Signed-off-by: Marcin Jahn <marcinj10@gmail.com> * Fix sample path in readme (#555) Signed-off-by: Xin Shi <xshi@microsoft.com> Co-authored-by: Mark Fussell <mfussell@microsoft.com> * Remove PR check for docker login (#565) * remove PR check for docker login Signed-off-by: tanvigour <tanvi.gour@gmail.com> * remove PR trigger for the workflow to fix docker login issue Signed-off-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Test validation cleanup (#569) * Test validation cleanup Signed-off-by: tanvigour <tanvi.gour@gmail.com> * add one response message in each of the validation steps Signed-off-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Fussell <mfussell@microsoft.com> Co-authored-by: Paul Yuknewicz <paulyuk@microsoft.com> Co-authored-by: Shubham Sharma <shubhash@microsoft.com> Co-authored-by: Marcin Jahn <marcinj10@gmail.com> Co-authored-by: Xin Shi <xshi@microsoft.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tanvigour tanvi.gour@gmail.com
Description
Remove the check for PR creation event so that docker login happens even when PRs are created
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: