Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-run support for workflow #935

Merged
merged 10 commits into from
Sep 27, 2023
Merged

Multi-run support for workflow #935

merged 10 commits into from
Sep 27, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Sep 22, 2023

Description

Added multi-run-app support and dapr.yaml to workflow quickstart

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

marcduiker and others added 4 commits September 20, 2023 17:41
@marcduiker
Add holopin.yml config (dapr#923)
e278ba4 
Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
@paulyuk @msfussell
Updating Readme's to default to dapr run -f . (dapr#874)
dcd97ee 
* Updating Invoke readme in C# to favor dapr run -f

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Adding back single app run steps and tests, but to the end.

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Update service_invocation/csharp/http/README.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>

* Updated and hardened test

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Invoke * and partial PubSub with multi-run files & readmes & tests

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Multi run done for Pubsub C#, Python and Node (http, sdk)

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Added Pubsub support for Go, Java

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* updating readmes with correct appid

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>

* Updating tests for PubSub and Service invoke to Paas with multiapp run

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* More fine tuning of pubsub tests (timeouts, step ends)

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

* Fixing Python FastAPI and C# Pubsub tests

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>

---------

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MacBook-Pro-2.local>
Co-authored-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
@paulyuk
Patching tests to pass (C# timing, Python uvicorn) (dapr#933)
7ee9b29 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Multi-run support for workflow
78e66b3 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk added the do-not-merge Do not merge the PR label Sep 22, 2023
@paulyuk paulyuk self-assigned this Sep 22, 2023
Paul Yuknewicz added 3 commits September 22, 2023 16:09
Removing component folder from run file to match readme
8fefd7b 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
aligning state store names on statestore
72d0791 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
Adding multi-app run for python and C#
0b09f11 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk paulyuk added P1 and removed do-not-merge Do not merge the PR labels Sep 23, 2023
@paulyuk paulyuk changed the base branch from master to release-1.12 September 27, 2023 14:11
Fixing MMD tests with tweaks
60584be 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@yaron2
Copy link
Member

yaron2 commented Sep 27, 2023

@paulyuk see conflicts.

Resolving conflicts. Merge branch 'release-1.12' of github.com:dapr/q…
8f90cc6 
…uickstarts into multiapp-wf

Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
@paulyuk
Copy link
Contributor Author

paulyuk commented Sep 27, 2023

@paulyuk see conflicts.

Done. I'll need another review pls.

Updating test env to Dapr runtime 1.12 RC4 and CLI RC2
5aade01 
Signed-off-by: Paul Yuknewicz <paulyuk@Pauls-MBP-2.lan>
msfussell
msfussell approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulyuk paulyuk merged commit 0ad816b into dapr:release-1.12 Sep 27, 2023
5 of 7 checks passed
This was referenced Sep 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamkm07 shivamkm07 shivamkm07 left review comments

@rabollin rabollin rabollin left review comments

@msfussell msfussell msfussell approved these changes

@yaron2 yaron2 yaron2 approved these changes

@RyanLettieri RyanLettieri RyanLettieri approved these changes

Assignees

@paulyuk paulyuk

Labels
P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@paulyuk @yaron2 @msfussell @shivamkm07 @rabollin @RyanLettieri @marcduiker