Tidy up the commit message to ensure it won't break the diff view.

Renamed the GLFileView's +parseHTML into something more meaningful regarding what it actually does. Also, the method might need to be moved to somewhere else...
darconeous · Apr 30, 2011 · 3f416bb · 3f416bb
1 parent a775582
commit 3f416bb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/GLFileView.h b/GLFileView.h
@@ -31,7 +31,7 @@
 - (void)showFile;
 - (void)didLoad;
 - (NSString *)parseBlame:(NSString *)txt;
-+ (NSString *)parseHTML:(NSString *)txt;
++ (NSString *)cleanupHTML:(NSString *)txt;
 + (NSString *)parseDiff:(NSString *)txt;
 + (NSString *)parseDiffTree:(NSString *)txt withStats:(NSMutableDictionary *)stats;
 + (NSString *)getFileName:(NSString *)line;

diff --git a/GLFileView.m b/GLFileView.m
@@ -110,7 +110,7 @@ - (void) showFile
             if(startFile==@"fileview"){
                 fileTxt=[file textContents:&theError];
                 if(!theError)
-                    fileTxt=[GLFileView parseHTML:fileTxt];
+                    fileTxt=[GLFileView cleanupHTML:fileTxt];
             }else if(startFile==@"blame"){
                 fileTxt=[file blame:&theError];
                 if(!theError)
@@ -240,13 +240,16 @@ - (void)closeView
 	[super closeView];
 }
 
-+ (NSString *) parseHTML:(NSString *)txt
++ (NSString *) cleanupHTML:(NSString *)txt
 {
-	txt=[txt stringByReplacingOccurrencesOfString:@"&" withString:@"&amp;"];
-	txt=[txt stringByReplacingOccurrencesOfString:@"<" withString:@"&lt;"];
-	txt=[txt stringByReplacingOccurrencesOfString:@">" withString:@"&gt;"];
+    NSMutableString *newTxt = [NSMutableString stringWithString:txt];
+	[newTxt replaceOccurrencesOfString:@"&" withString:@"&amp;" options:NSLiteralSearch range:NSMakeRange(0, [newTxt length])];
+	[newTxt replaceOccurrencesOfString:@"<" withString:@"&lt;" options:NSLiteralSearch range:NSMakeRange(0, [newTxt length])];
+	[newTxt replaceOccurrencesOfString:@">" withString:@"&gt;" options:NSLiteralSearch range:NSMakeRange(0, [newTxt length])];
+    [newTxt replaceOccurrencesOfString:@"\"" withString:@"&quot;" options:NSLiteralSearch range:NSMakeRange(0, [newTxt length])];
+    [newTxt replaceOccurrencesOfString:@"'" withString:@"&apos;" options:NSLiteralSearch range:NSMakeRange(0, [newTxt length])];
 
-	return txt;
+	return newTxt;
 }
 
 + (NSString *)parseDiffTree:(NSString *)txt withStats:(NSMutableDictionary *)stats
@@ -296,7 +299,7 @@ + (NSString *)parseDiffTree:(NSString *)txt withStats:(NSMutableDictionary *)sta
 
 + (NSString *)parseDiff:(NSString *)txt
 {
-	txt=[self parseHTML:txt];
+	txt=[self cleanupHTML:txt];
 
 	NSMutableString *res=[NSMutableString string];
     NSScanner *scan=[NSScanner scannerWithString:txt];
@@ -504,7 +507,7 @@ +(BOOL)isStartBlock:(NSString *)line
 
 - (NSString *) parseBlame:(NSString *)txt
 {
-    txt=[GLFileView parseHTML:txt];
+    txt=[GLFileView cleanupHTML:txt];
 
     NSArray *lines = [txt componentsSeparatedByString:@"\n"];
     NSString *line;

diff --git a/PBWebHistoryController.m b/PBWebHistoryController.m
@@ -167,7 +167,8 @@ - (NSString *)parseHeader:(NSString *)txt withRefs:(NSString *)badges
 			}
 		}else{
 			if (subj) {
-				[subject appendString:[NSString stringWithFormat:@"%@<br/>",[line stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]]]];
+                NSString *trimmedLine = [line stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
+				[subject appendString:[NSString stringWithFormat:@"%@<br/>",[GLFileView cleanupHTML:trimmedLine]]];
 			}else{
 				NSArray *comps=[line componentsSeparatedByString:@" "];
 				if([comps count]==2){