-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: preparation for merge with nuxt-cookie-control #95
Conversation
BREAKING CHANGE: Setting an initial state for a cookie (i.e. enabled instead of disabled) was never properly implemented. To avoid confusion, this setting is removed. It continues to be possible to set `isIframeBlocked` true, though as of 2022-03-30 it is not yet implemented for vite (#79).
TODO:
|
I changed the base to |
Great, thanks! I'll create a new stackblitz example and connect it with README |
Should we add Nuxt 2 support to this codebase before merging the modules? I'm actually not that interested in implementing that, I'm a friend of giving reasons to upgrade 😁 |
I think we should just add disclaimer for it. |
agreed! |
Great! I'll add it in README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darioferderber would you mind resolving the merge conflicts?
Closing this for now due to the PR being stale. Feel free to come back anytime to continue work on it! 🙌 |
📚 Description
Changes in package.json and README.md to prepare for merge with nuxt-cookie-control
📝 Checklist