Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preparation for merge with nuxt-cookie-control #95

Closed
wants to merge 50 commits into from

Conversation

darioferderber
Copy link
Collaborator

@darioferderber darioferderber commented May 3, 2023

📚 Description

Changes in package.json and README.md to prepare for merge with nuxt-cookie-control

📝 Checklist

  • All commits follow the Conventional Commit format
  • The PR's title follows the Conventional Commit format

dargmuesli and others added 30 commits March 30, 2023 05:02
BREAKING CHANGE: Setting an initial state for a cookie (i.e. enabled instead of disabled) was never properly implemented. To avoid confusion, this setting is removed. It continues to be possible to set `isIframeBlocked` true, though as of 2022-03-30 it is not yet implemented for vite (#79).
@darioferderber
Copy link
Collaborator Author

darioferderber commented May 3, 2023

TODO:

  • refactor Stackblitz example

@dargmuesli dargmuesli changed the base branch from master to beta May 4, 2023 14:50
@dargmuesli dargmuesli marked this pull request as draft May 4, 2023 14:56
@dargmuesli
Copy link
Owner

I changed the base to beta so that we have an additional layer for checking that everything goes well :) also, I marked the PR as draft as you mentioned a TODO is still missing 🙋

@darioferderber
Copy link
Collaborator Author

Great, thanks! I'll create a new stackblitz example and connect it with README

@dargmuesli
Copy link
Owner

Should we add Nuxt 2 support to this codebase before merging the modules? I'm actually not that interested in implementing that, I'm a friend of giving reasons to upgrade 😁

@darioferderber
Copy link
Collaborator Author

I think we should just add disclaimer for it.
Something like "For Nuxt 2 please use versions < 3.0.0" and that's it 🙂

@dargmuesli
Copy link
Owner

agreed!

@darioferderber
Copy link
Collaborator Author

Great! I'll add it in README

Base automatically changed from beta to master July 12, 2023 15:44
Copy link
Owner

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darioferderber would you mind resolving the merge conflicts?

@dargmuesli
Copy link
Owner

Closing this for now due to the PR being stale. Feel free to come back anytime to continue work on it! 🙌

@dargmuesli dargmuesli closed this Aug 14, 2023
@dargmuesli dargmuesli deleted the refactor/preparation-for-merge branch August 14, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants