Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deploy lock to a darklang canvas #4703

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Move deploy lock to a darklang canvas #4703

merged 4 commits into from
Jan 15, 2023

Conversation

pbiggar
Copy link
Member

@pbiggar pbiggar commented Jan 12, 2023

Changelog:

Internal
- Move deployment lock to a darklang canvas

The deploy lock uses a storage bucket, which requires cloud permissions to be put almost everywhere during a deploy.

This reimplements the deploy lock as a simple dark DB, in https://darklang.com/a/ops-circleci, and rewrites the deploy lock scripts to use it.

There is a secret in that canvas already. For deploying locally, which we almost never do, we could stop using the deploy lock perhaps, or have a key locally. I'm leaving that decision to a later day, when we have more experience with how the goes.

  • Followup: restrict gcp deployment permissions to only the darklang-static-assets bucket

@StachuDotNet
Copy link
Member

I'll be able to more fully review this in an ~hour, but:
https://darklang.com/a/ops-circleci#handler=853689901&trace=fe7a4e3f-0eee-8319-4385-bf4ab251ccf5
the recent traces of this all seem to return a 400 with body account_inactive - is that expected?

@pbiggar
Copy link
Member Author

pbiggar commented Jan 14, 2023

I'll be able to more fully review this in an ~hour, but:
https://darklang.com/a/ops-circleci#handler=853689901&trace=fe7a4e3f-0eee-8319-4385-bf4ab251ccf5
the recent traces of this all seem to return a 400 with body account_inactive - is that expected?

That handler isn't related to this PR - that one does slack messages from builds, which no longer work because we disabled access to Slack as part of rolling creds recently. That should be switched to discord soon.

@pbiggar pbiggar merged commit 76d0c04 into main Jan 15, 2023
@pbiggar pbiggar deleted the paul/fix-deploy-lock branch January 15, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants