Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add andThen2 with Interface, Documentation and Tests #178

Closed

Conversation

shubhamkumar13
Copy link

adding andThen2 as a response to issue #160

@shubhamkumar13
Copy link
Author

shubhamkumar13 commented Sep 17, 2020

Forgot to add tests 🤦‍♂️
Going to check the doc generation failures.

@shubhamkumar13
Copy link
Author

shubhamkumar13 commented Sep 17, 2020

The tests that are failing as a result of me not having a proper way of formatting re/ml files.

Any suggestion regarding this would be very helpful, I created a fresh switch for tablecloth with the following packages (as a result of make deps-native)

# Packages matching: installed
# Name                  # Installed # Synopsis
alcotest                1.2.3       Alcotest is a lightweight and colourful test framework
astring                 0.8.5       Alternative String module for OCaml
base                    v0.14.0     Full standard library replacement for OCaml
base-bigarray           base
base-threads            base
base-unix               base
cmdliner                1.0.4       Declarative definition of command line interfaces for OCaml
conf-m4                 1           Virtual package relying on m4
cppo                    1.6.6       Code preprocessor like cpp for OCaml
csexp                   1.3.2       Parsing and printing of S-expressions in Canonical form
dune                    2.7.1       Fast, portable, and opinionated build system
dune-configurator       2.7.1       Helper library for gathering system configuration
fix                     20200131    Facilities for memoization and fixed points
fmt                     0.8.8       OCaml Format pretty-printer combinators
fpath                   0.7.3       File system paths for OCaml
junit                   2.0.2       JUnit XML reports generation library
junit_alcotest          2.0.2       JUnit XML reports generation for alcotest tests
menhir                  20200624    An LR(1) parser generator
menhirLib               20200624    Runtime support library for parsers generated by Menhir
menhirSdk               20200624    Compile-time library for auxiliary tools related to Menhir
merlin-extend           0.6         A protocol to provide custom frontend to Merlin
ocaml                   4.10.0      The OCaml compiler (virtual package)
ocaml-config            1           OCaml Switch Configuration
ocaml-migrate-parsetree 1.7.3       Convert OCaml parsetrees between different versions
ocaml-system            4.10.0      The OCaml compiler (system version, from outside of opam)
ocamlbuild              0.14.0      OCamlbuild is a build system with builtin rules to easily b
ocamlfind               1.8.1       A library manager for OCaml
odoc                    1.5.1       OCaml documentation generator
ppx_derivers            1.2.1       Shared [@@deriving] plugin registry
ptime                   0.8.5       POSIX time for OCaml
re                      1.9.0       RE is a regular expression library for OCaml
reason                  3.6.0       Reason: Syntax & Toolchain for OCaml
result                  1.5         Compatibility Result module
seq                     base        Compatibility package for OCaml's standard iterator type st
sexplib0                v0.14.0     Library containing the definition of S-expressions and some
stdlib-shims            0.1.0       Backport some of the new stdlib features to older compiler
topkg                   1.0.2       The transitory OCaml software packager
tyxml                   4.4.0       TyXML is a library for building correct HTML and SVG docume
uchar                   0.0.2       Compatibility library for OCaml's Uchar module
uuidm                   0.9.7       Universally unique identifiers (UUIDs) for OCaml
uutf                    1.0.2       Non-blocking streaming Unicode codec for OCaml

Also I use vscode with OCaml Formatter and OCaml Platform

And I don't often use formatter / linter for ocaml development so I'm not sure what I should use

@pbiggar
Copy link
Member

pbiggar commented Sep 22, 2020

Just to update you on this, I'm adding CI so we can establish what versions we support, and then we should be able to get this and a few other of your PRs merged.

@shubhamkumar13
Copy link
Author

Just to update you on this, I'm adding CI so we can establish what versions we support, and then we should be able to get this and a few other of your PRs merged.

Thanks! Sorry I didn't look into the build matrix.

@pbiggar
Copy link
Member

pbiggar commented Sep 29, 2020

This is probably good to merge - can you rebase it off main so that CI will run?

Thanks!

- Reformat Interface file docs to avoid failure
- Remove the changes in TableclothMap - related to PR#177
- Add the changes from darklang#177
- Squash commit
test reformats (sorry for the unnecessary commits :) )
- dune build @fmt
- dune promote
@pbiggar pbiggar deleted the branch darklang:master August 17, 2021 14:56
@pbiggar pbiggar closed this Aug 17, 2021
@pbiggar
Copy link
Member

pbiggar commented Aug 18, 2021

This was automatically closed when I deleted the master branch, apologies. We'll try to get this merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants