-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add andThen2 with Interface, Documentation and Tests #178
Conversation
Forgot to add tests 🤦♂️ |
a802185
to
edbefdf
Compare
The tests that are failing as a result of me not having a proper way of formatting re/ml files. Any suggestion regarding this would be very helpful, I created a fresh switch for tablecloth with the following packages (as a result of
Also I use vscode with OCaml Formatter and OCaml Platform And I don't often use formatter / linter for ocaml development so I'm not sure what I should use |
Just to update you on this, I'm adding CI so we can establish what versions we support, and then we should be able to get this and a few other of your PRs merged. |
Thanks! Sorry I didn't look into the build matrix. |
This is probably good to merge - can you rebase it off main so that CI will run? Thanks! |
- Reformat Interface file docs to avoid failure - Remove the changes in TableclothMap - related to PR#177
- Add the changes from darklang#177 - Squash commit test reformats (sorry for the unnecessary commits :) )
- dune build @fmt - dune promote
c2bab63
to
d3032ba
Compare
This was automatically closed when I deleted the master branch, apologies. We'll try to get this merged soon. |
adding andThen2 as a response to issue #160