Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Djangoify part2 data UI bugs #124

Merged
merged 45 commits into from
Aug 4, 2021
Merged

Djangoify part2 data UI bugs #124

merged 45 commits into from
Aug 4, 2021

Conversation

ichang1
Copy link
Collaborator

@ichang1 ichang1 commented Jul 24, 2021

  1. Fixed delete not working for experiment
  2. Made experiment list view be auto-generated like the other list views because the code is the same and there were a lot of changes to the get_queryset_method
  3. Added a SlugField to most models that use some of the model's fields to create the slug. The slug is used internally to help filter querysets based on a filter_val when a model has a ManyToManyField that is displayed in the UI
  4. Used SlugField to fix filtering
  5. Fixed sorting by a ManyToManyField in UI by annotating queryset and sorting by number of m2m relations instead

@ichang1
cleaned up files
52418cb
@ichang1
added inline edoc class
c436bdd
@ichang1
edocument was never added to urls
748ee68
@ichang1
added edocument to urls after fixing it a little
2ec1f79
@ichang1
took out edocument from auto gen views
d5a5c46
@ichang1
status column missing from material
e52e94a
@ichang1
added helper methods to filter and sort manytomany
91941df
@ichang1
fixed sorting, but only for forward related fields
07ffdb1
@ichang1
added backward related fields
d1814ed
@ichang1
took out old fields from inventory material detail
d13ed91
@ichang1
status to status.description
7db6dad
@ichang1
fixed export view
0417f79
@ichang1
fixed list methods and export methods
a8e0e3a
@ichang1
cached queryset from listview for export view
58890b6
@ichang1
added added org to person in views
3f67edf
@ichang1
fixed model tag and moved tag out of detail dict
0b669e7
@ichang1
html change for prev commit
b236add
@ichang1
tag
ce8435c
@ichang1
added middle name for person in list view
bc81a7b
@ichang1
filtered out empty string for list and detail
afed093
@ichang1
filter kwargs was taking from ordering and export model name was wrong
f2aa608
@ichang1
added custom context_object_name to views
7a22864
@ichang1
fixed missing export views
f9dd83b
@ichang1
took out print statement from generic list view
31faa92
@ichang1
Merge branch 'djangoify_part2' into djangoify_part2_data_ui_bugs
94ff9da
@ichang1
move experiment list view to be auto generated
d7c6c45
@ichang1
atook out getattr_or_none cause it's built-in
eb57ca5
@ichang1
new utils dir cause old one had model dependencies
994d6cf
@ichang1
added custom slug field for models
005ddf8
@ichang1
got rid of redundant code in model view generic
3bcecde
jpannizzo
jpannizzo requested changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@jpannizzo jpannizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the experiment templates are present in the experiment list and the experiment details form is incorrect and has been changed. None of the details of the experiment are present and the edocuments form is present instead

@jpannizzo
Copy link
Contributor

looks like experiment details is using the edocument form in this request

@jpannizzo jpannizzo merged commit f630c23 into djangoify_part2 Aug 4, 2021
@ichang1 ichang1 deleted the djangoify_part2_data_ui_bugs branch August 5, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpannizzo jpannizzo jpannizzo requested changes

@vshekar vshekar Awaiting requested review from vshekar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichang1 @jpannizzo