Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to run on protected pages #3426

Merged
merged 6 commits into from
Aug 24, 2020
Merged

Add option to run on protected pages #3426

merged 6 commits into from
Aug 24, 2020

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Aug 15, 2020

Possible bug with render of UI that when toggling the option and staying in the same pop-up(so not closing it after toggling) that the Toggle site button is still rendering the old option so

Disabled -> Enabled. Toggle site still shows the protected CSS.
Enabled -> Disabled. Toggle site still let you toggle the site.

@Gusted
Add option to run on protected pages
6fbe354 
- Add a option under sitelist to allow people to disable the check if a site is protected
- Let users allow to darken sites that aren't protected in there Environment(Firefox about:config)
- Resolves #912
- Resolves #1254
This was referenced Aug 15, 2020
Closed
Closed
Closed
alexanderby
alexanderby requested changes Aug 21, 2020
View reviewed changes
src/definitions.d.ts Outdated Show resolved Hide resolved
src/defaults.ts Outdated Show resolved Hide resolved
alexanderby
alexanderby requested changes Aug 21, 2020
View reviewed changes
src/background/extension.ts Outdated Show resolved Hide resolved
src/background/tab-manager.ts Outdated Show resolved Hide resolved
src/background/tab-manager.ts Outdated Show resolved Hide resolved
src/ui/popup/site-list-page/index.tsx Outdated Show resolved Hide resolved
src/ui/popup/site-list-page/index.tsx Outdated Show resolved Hide resolved
src/ui/popup/site-list-page/index.tsx Outdated Show resolved Hide resolved
src/defaults.ts Outdated Show resolved Hide resolved
src/ui/connect/mock.ts Outdated Show resolved Hide resolved
@Gusted Gusted merged commit cd915d5 into master Aug 24, 2020
@Gusted Gusted deleted the Unrestricted-Patch branch August 24, 2020 16:05
This was referenced Aug 29, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderby alexanderby alexanderby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Work on protected pages Option for running extension on restricted URLs
2 participants
@Gusted @alexanderby