[BUG] protected pages cannot be disabled when granted permission

[erkinalp]

Describe the bug

If a protected page is allowed to be modified by darkreader, that page cannot be toggled

Expected behavior

If you grant permission for darkreader to work on protected pages, the dark mode should be able to be toggled just like another website.

Screenshots

Dark mode cannot be disabled on addons.mozilla.org (recommendation of Dark Reader is by pure chance):

I tried screenshotting the settings window but it disappears when I capture the picture.

System Information:

• OS: Ubuntu 20.04
• Browser: Firefox 81 beta
• Dark Reader version: GitHub development snapshot mentioned on Prevent whiteflash on inital document_start #3533

[Gusted]

Hi @erkinalp!

By any chance you had a look over at #3426
Also, it should just toggle(after you refresh the UI it's a current bug that it will render the old view)

Regards,
Gusted

[erkinalp]

I did. Even closing&reopening the tab did not change the result, though.

[Gusted]

@erkinalp
As it seems you have know how to install snapshots. I don't need some fancy instructions
support.zip
Go to the master branch, fetch and pull the latest source code. Unzip support.zip.
git apply support.patch
and than you can build dark reader and it should be fixed.

[DUOLabs333]

I still have this issue: I cleared extensions.webextensions.restrictedDomains, but Dark Reader still won't work on the page. I'm on 4.9.51.

[Gusted]

I still have this issue: I cleared extensions.webextensions.restrictedDomains, but Dark Reader still won't work on the page. I'm on 4.9.51.

Did you enable the corresponding setting in Dark Reader? By-Default dark reader won't try to modify protected site(to avoid errors )

[DUOLabs333]

What setting?

[Gusted]

Click Dark Reader icon.
Click Dev tools (in the bottom-right corner).
Click Preview new design.
Settings -> Site list -> Enable on restricted pages.

[DUOLabs333]

Oh, it's on the new design. Thanks.