Fix render bug for protected sites

[Gusted]

• tab.isProtected should not use enableForProtectedPages option as it doesn't get up-to-date data and will return the old value.
• Real-time site-toggle disable according isProtected logic and enableForProtectedPages option.
• Make test according to the good visa-versa logic(Forgot to update in previous PR)
• Resolves [BUG] protected pages cannot be disabled when granted permission #3548

[Gusted]

@erkinalp
Commit fb99c33 fixed this reversed behavior and is now behaving how it should be.

[erkinalp]

thanks

[erkinalp]

another bug: non-protected pages cannot be toggled now if you disable "enable on protected pages".

[Gusted]

Shit here we go again.

[Gusted]

@erkinalp
Are you sure? I tried a fresh npm run debug of this branch and it just behaves how it should be. Maybe something in your sitelist?

[erkinalp]

Certainly sure. I tried a npm run release, though. You know, it is a thing that some things only fail in release builds.

[Gusted]

You know, it is a thing that some things only fail in release builds.

You know, the thing with our build workflow. The output of the code is always the same and gives identical(Other than some more debug info and a inline-source-map that doesn't affect the actual code) output and results.

Certainly sure. I tried a npm run release,

Noppes and nana, it still works. I suggest to remove the extension and than re-side-load it.

[erkinalp]

Re-side loaded but still having the same problem.

[Gusted]

What if you try to sideload this version of the branch

[erkinalp]

That version fixed the problem 🥇

[Gusted]

Well, that was commit 6b309fd but than npm run debug