Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for logo and More arrow icon for BBC #814

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

IgorKrupenja
Copy link
Contributor

Note that using bbc.com/* is not posssible as it breaks the logo at bbc.com/home and bbc.com/reel

Note that using `bbc.com/*` is not posssible as it breaks the logo at bbc.com/home and bbc.com/reel
@alexanderby
Copy link
Member

OK, let it be. I think it will be improved when we finally rework URL templates, so writing bbc.com !bbc.com/reel will make it shorter.

@alexanderby alexanderby merged commit 1cb594c into darkreader:master Nov 19, 2018
@ghost
Copy link

ghost commented Dec 2, 2018

Suddenly, this fix inverts logo incorrectly and the site itself automatically gets successful dark theme without any config.
My settings: Debian 9.6/Firefox 64.0b14

With fix:

image

Without:

image

But if it's just on my side, I'd recommend to save some space in config file by using regexp:
bbc.com/(news|sport|weather|travel|capital|autos|culture|future|sounds|food|bitesize|earth)

@IgorKrupenja
Copy link
Contributor Author

IgorKrupenja commented Dec 5, 2018

Thanks, did not know that Dark Reader Dev tools support regex!

This looks like something browser-specific. The BBC logo looks OK in Chrome with this fix but I have now tried in Firefox and there indeed it looks OK without the fix (and broken with the fix).

I guess it would be better for the maintainer to revert the fix unless there is a way to implement browser-specific rules.

@alexanderby
Copy link
Member

The dev tools are not supposed to support RegExps, it is a side effect. Maybe patterns like this will be allowed, but still the work on it is not started.

It looks like some difference in image analysis between Chrome and Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants