Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple parametric masks #10326

Closed
tpapp opened this issue Nov 4, 2021 · 11 comments
Closed

multiple parametric masks #10326

tpapp opened this issue Nov 4, 2021 · 11 comments
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus feature: new new features to add no-issue-activity scope: image processing correcting pixels scope: UI user interface and interactions

Comments

@tpapp
Copy link

tpapp commented Nov 4, 2021

Is your feature request related to a problem? Please describe.

Occasionally one would like to select a union of various properties that can be described by parametric masks (eg skin color and blue for eyes, nothing else).

Describe the solution you'd like

Multiple parametric masks in a module instance, to be combined under the same rules as drawn elements and parametric masks.

Alternatives

For some transformations, it is possible to work around this problem by using multiple module instances with the parametric mask elements that would form the union above. However, that becomes tedious when information would be lost by a transformation (eg desaturate some colors), or the transformations are nonlinear.

For example, to desaturate everything but skin tones and blue, one would currently desaturate from red to skin tones, then from skin tones to blue, then from blue onwards. This requires 3 module instances, but all that changes is the mask.

Naturally, drawn masks can be a workaround too and are very powerful, but address a different problem.

Additional context

Discussion.

@TurboGit
Copy link
Member

TurboGit commented Nov 6, 2021

If I understand your request I fear that this will make the parametric masks UI even more complex. I think we have reached some complexity bound at the moment. All in all, don't hold your breath on this :)

@Nilvus
Copy link
Contributor

Nilvus commented Nov 7, 2021

I fear too that this would add too much complexity.

@Nilvus Nilvus added controversial this raises concerns, don't move on the technical work before reaching a consensus feature: new new features to add scope: image processing correcting pixels scope: UI user interface and interactions labels Nov 7, 2021
@Dannny1
Copy link

Dannny1 commented Nov 11, 2021

Just an idea. Maybe separating all masks to mask manager and enabling mask centric workflow/view instead of/with module centric would make some edits faster and make less clutter.
E.g. when selecting a mask it would show related modules in special module group....

@tpapp
Copy link
Author

tpapp commented Nov 11, 2021

Yes, making masks first class would help solve this. Specifically, all this would require is making a mask from existing masks and then using it.

@tpapp
Copy link
Author

tpapp commented Nov 15, 2021

I figured out a workaround with raster masks.

  1. Pick a module that (a) has a no-op mode and (b) comes earlier in the pipeline than the change you want to make (eg exposure with zero correction). Create one instance for each parametric mask you need.

  2. Use each mask in subsequent corresponding instance of the module you want to apply as a raster mask.

@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@s7habo
Copy link

s7habo commented Jan 18, 2022

I will also welcome this functionality.
Perhaps another option would be - if customizing the masks is too complex - to have a module similar to color zones or color look up table that are adapted to scene-reffered workflow.

@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@yaitskov
Copy link

yaitskov commented Aug 13, 2022

Today I realized too that I need a parametric mask manager.
Single parametric mask cannot tackle blond dyed hair overlapping with skin body and model is behind a dark rock - dyed hair and skin look the same and non-dyed hair merge with rock and they both are interleaving curly stands, so hand drawn mask doesn't help a lot.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@github-actions
Copy link

This issue was closed because it has been inactive for 300 days since being marked as stale. Please check if the newest release or nightly build has it fixed. Please, create a new issue if the issue is not fixed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus feature: new new features to add no-issue-activity scope: image processing correcting pixels scope: UI user interface and interactions
Projects
None yet
Development

No branches or pull requests

6 participants