Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving edited metadata in the JPEG exif on export #11466

Closed
axettone opened this issue Apr 6, 2022 · 15 comments
Closed

Saving edited metadata in the JPEG exif on export #11466

axettone opened this issue Apr 6, 2022 · 15 comments
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus no-issue-activity scope: UI user interface and interactions

Comments

@axettone
Copy link

axettone commented Apr 6, 2022

Feature request: I spend so much time editing metadata in my photographs, but I can't see anything (other then CAMERA metadata) in the exported JPEG's EXIF.

If I edit "title", "author" (...) fields in metadata, I'd like to see them in the exif in the exported JPEG

@kmilos
Copy link
Contributor

kmilos commented Apr 6, 2022

See recent #11455

@axettone
Copy link
Author

axettone commented Apr 6, 2022

See recent #11455

It's not about EXIF data created by the camera that goes away. I meant the metadata you set in DT.

@kmilos
Copy link
Contributor

kmilos commented Apr 6, 2022

And I meant check the export settings.

@axettone
Copy link
Author

axettone commented Apr 6, 2022

And I meant check the export settings.

Thank you! It was not so easy to find. I think it would be better to put a checkbox like "export metadata" in the "Export" panel with a "Advanced option" button (IMHO).

@Nilvus
Copy link
Contributor

Nilvus commented Apr 6, 2022

And I meant check the export settings.

Thank you! It was not so easy to find. I think it would be better to put a checkbox like "export metadata" in the "Export" panel with a "Advanced option" button (IMHO).

That's not same thing and it's had been done on purpose to not set them by default and let them in export setting. Metadata could be some private datas and, for example, publishing images on the web could show not wanted datas. It's done for privacy reasons.

Putting a checkbox like what you propose would not help as this will not answer on which datas to set by default or not? All, I'm quite sure many will not like or be agree with that. Which ones would suit most people (I'm quite sure this will be hard to define)?

@Nilvus Nilvus added scope: UI user interface and interactions controversial this raises concerns, don't move on the technical work before reaching a consensus labels Apr 6, 2022
@axettone
Copy link
Author

axettone commented Apr 7, 2022

That's not same thing and it's had been done on purpose to not set them by default and let them in export setting. Metadata could be some private datas and, for example, publishing images on the web could show not wanted datas. It's done for privacy reasons.

Putting a checkbox like what you propose would not help as this will not answer on which datas to set by default or not? All, I'm quite sure many will not like or be agree with that. Which ones would suit most people (I'm quite sure this will be hard to define)?

I totally agree about your concerns about privacy. I know how much useful information you can gather from metadata. More: how much bad companies can use this data against people. Metadata should be set off by default. Let's forget the checkbox... what about a simple button "Metadata settings..." in the export panel? Expert users know about metadata, but I believe the current way of reaching these settings is not intuitive. I believe that this button should be placed in the "format options" subpanel, so to speak. Of course, mine is only an opinion. Anyway thanks for the help, now I know how.

@axettone
Copy link
Author

axettone commented Apr 7, 2022

I think this button would work even as an effective "reminder", increasing the privacy level. If I set some metadata to be exported today, a button would remind me to set them off tomorrow. The "preferences" menu item does not work well this way.

@phweyland
Copy link
Contributor

At the beginning it was a gear wheel button next to the export one. I moved it to the module's preferences when working on other modules' preferences.
There is no issue for me to go back to the original configuration. @elstoc if my memory is not too bad you were not so happy with that change. What's your view now ?
Any other opinion ?

@elstoc
Copy link
Contributor

elstoc commented Apr 8, 2022

I felt that the preferences item in the presets menu often just hid useful settings away and made them harder to find. IMO virtually all of them would have been better as an in-module button or just being left in the global preferences (especially now that we're talking about some sort of "expert mode" that will expose more preferences).

Specifically, I still think that the preferences in export made much more sense as an extra button - we certainly weren't saving any space in the module by moving it.

@Nilvus
Copy link
Contributor

Nilvus commented Apr 8, 2022

At least, we could add a message to explain possibility/need to set metadata, on tooltip when hovering export button. I plan to propose something for that.

About where preferences are on the module, as a gear button or in an hamburger menu, it's the same for me. Actual settings on preferences of the module are better related to the module than inside main preferences for me.

@phweyland
Copy link
Contributor

Set back the metadata preferences button.
BTW don't forget metadata preferences are embedded in presets (each preset can have its own metadata preferences).

@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@FranJNS
Copy link

FranJNS commented Jun 15, 2022

Hi! I'm the same problem when I export png. EXIF data doesn't export with checkbox active. In TIFF mode works good.

@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@github-actions
Copy link

This issue was closed because it has been inactive for 300 days since being marked as stale. Please check if the newest release or nightly build has it fixed. Please, create a new issue if the issue is not fixed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus no-issue-activity scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants