Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor refresh issue on color calibration module #14518

Closed
Nilvus opened this issue May 16, 2023 · 2 comments · Fixed by #15497
Closed

Some minor refresh issue on color calibration module #14518

Nilvus opened this issue May 16, 2023 · 2 comments · Fixed by #15497
Assignees
Labels
bug: pending someone needs to start working on that scope: UI user interface and interactions
Milestone

Comments

@Nilvus
Copy link
Contributor

Nilvus commented May 16, 2023

Describe the bug

Since #14498 is fixed, if I change a setting on white balance then revert back to default setting, color calibration module shows "error, on white balance module" with red warning. This should disappear when put back related white balance default and at least on opening module. This is no more the case. But error message disappear when quitting darkroom and go back to the image.

I think some refresh issue is missing after change regarding fix of #14498. @ralfbrown?

Steps to reproduce

With an image with scene-referred workflow, so white balance on bulb icon (6502K value):

  1. click on pencil icon on white balance module
  2. click on bulb icon to revert to default settings
  3. see error message appear on color calibration module.

Quit darkroom and go back to the image: the error message had disappear.

Expected behavior

error message disappear as soon as white balance setting is again ok for color calibration module

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you install darktable from?

darktable.org

darktable version

last master at the time of writing that issue

What OS are you using?

Linux

What is the version of your OS?

Debian Sid

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@Nilvus Nilvus added scope: UI user interface and interactions bug: pending someone needs to start working on that labels May 16, 2023
@Nilvus Nilvus added this to the 4.4 milestone May 16, 2023
@Nilvus Nilvus modified the milestones: 4.4, 4.6 Sep 3, 2023
@jenshannoschwalm
Copy link
Collaborator

@Nilvus i think the underlying problem is something else. The error messages are generated in some "tricky" way. The colorbalance warning is checked while processing the module. Sounds good but in case of a cache hit we might (you changed temperature some times for example) have no processing of that module and so the warning stays ...

@Nilvus
Copy link
Contributor Author

Nilvus commented Sep 15, 2023

Probably. I don't know how this works on the code but on the UI, that's why I succeed to reproduce. It remains a minor bug as processing works as it should and error message could be disabled easily but would be good if this could be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that scope: UI user interface and interactions
Projects
None yet
3 participants