Rework temperature and channelmixerrgb #15497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a `chroma` struct in dev (like a proxy) holding all required and available white balance data for the current image (D65, as_shot and currently used) allowing runtime a) check - are we using D65? b) access of modules to the other coeffs for improved results c) easier and safe checks for chroma correction related trouble messages
TurboGit
added
scope: color management
TurboGit
approved these changes
Oct 27, 2023
|
Thanks @jenshannoschwalm for your work and the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
chromastruct in dev (like a proxy) holding all required and available white balance data for the current image (D65, as_shot and currently used) allowing runtimea) check - are we using D65?
b) access of modules to the other coeffs for improved results c) easier and safe checks for chroma correction related trouble messages
@TurboGit for you as this might be easier to review.
It's a stripped down version of #15461, this should not change anything in current master behaviour except safer message generation and keeping data in the dev chroma struct. The other pr could be rebased on this after possibly getting merged.
Fixes #14518