Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default activation for filmic and exposure if preset created #14799

Closed
ctouz opened this issue Jun 28, 2023 · 3 comments · Fixed by #14804
Closed

No default activation for filmic and exposure if preset created #14799

ctouz opened this issue Jun 28, 2023 · 3 comments · Fixed by #14804
Assignees
Labels
bug: pending someone needs to start working on that release notes: pending scope: codebase making darktable source code easier to manage understood: clear devs have a complete bug report with all the relevant info to start fixing
Milestone

Comments

@ctouz
Copy link

ctouz commented Jun 28, 2023

Describe the bug

if there are no presets for film (or exposure) relative to a camera body, the auto mode relative to the scene opens the 2 modules at 'default' but as soon as one of the two modules is associated with a camera body, it no longer appears for another camera body (it should appear at default). you have to redo a preset for each camera body...

Steps to reproduce

  1. activate the scene-preferred (filmic) workflow
    2.create a preset in filmic and/or an exposure for a body type
    3.import raw data from another body
    4.check the history to ensure that filmic and/or the default exposure are not activated...

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you install darktable from?

darktable.org

darktable version

4.4.0

What OS are you using?

Linux

What is the version of your OS?

Manjaro

Describe your system?

Manjaro kernen 6.1
ram 16g
graphic card rtx3050

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

rtx 3050

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

with the scene-refered workflow setting (filmic) if I create a preset for a camera in filmic or exposure and then import raw from another camera filmic and exposure are disable

@TurboGit TurboGit self-assigned this Jun 28, 2023
@TurboGit
Copy link
Member

I'll have a look, I know what is going on. This behavior is due to recent workflow rework.

@TurboGit TurboGit added understood: clear devs have a complete bug report with all the relevant info to start fixing scope: codebase making darktable source code easier to manage bug: pending someone needs to start working on that release notes: pending labels Jun 28, 2023
@ctouz
Copy link
Author

ctouz commented Jun 28, 2023

also whether in scene-referred (filmic) or (sigmoide), if there is a preset in filmicrgb and in sigmoide for the same body, when a raw from this body is imported the filmic module and the sigmoide module are both activated

TurboGit added a commit to TurboGit/darktable that referenced this issue Jun 29, 2023
When checking if a default auto-preset is to be used properly
check that user's preset do apply to the current image. That
is for the camera/lens/iso/exposure/aperture of the image.

Fixes darktable-org#14799.
TurboGit added a commit to TurboGit/darktable that referenced this issue Jun 29, 2023
When checking if a default auto-preset is to be used properly
check that user's preset do apply to the current image. That
is for the camera/lens/iso/exposure/aperture of the image.

Fixes darktable-org#14799.
@TurboGit
Copy link
Member

@ctouz : If you can compile dt, please can you check #14804. TIA.

@TurboGit TurboGit added this to the 4.4.1 milestone Jun 29, 2023
TurboGit added a commit that referenced this issue Jun 29, 2023
When checking if a default auto-preset is to be used properly
check that user's preset do apply to the current image. That
is for the camera/lens/iso/exposure/aperture of the image.

Fixes #14799.
TurboGit added a commit that referenced this issue Jun 29, 2023
When checking if a default auto-preset is to be used properly
check that user's preset do apply to the current image. That
is for the camera/lens/iso/exposure/aperture of the image.

Fixes #14799.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that release notes: pending scope: codebase making darktable source code easier to manage understood: clear devs have a complete bug report with all the relevant info to start fixing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants