Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying multiple styles with multiple module instances produces order-dependent result #15806

Closed
kofa73 opened this issue Dec 2, 2023 · 0 comments · Fixed by #15807
Closed
Assignees
Labels
bug: pending someone needs to start working on that difficulty: hard big changes across different parts of the code base priority: medium core features are degraded in a way that is still mostly usable, software stutters reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Milestone

Comments

@kofa73
Copy link
Contributor

kofa73 commented Dec 2, 2023

Describe the bug

This is from https://discuss.pixls.us/t/how-to-add-two-watermarks-on-a-image-in-darktable/40653/10. The OP asked about multiple watermarks. To demonstrate the use of multiple instances, I created two styles, one with watermarks in the top/bottom left corners, one with watermarks in the top left/right corners.

Applying them in "top", then "left" displays 3 watermarks (top left, top right, bottom left).
Applying them in "left", then "top" order displays only the top 2; bottom left is removed.

Steps to reproduce

  1. Import the styles
  2. Apply them in the order "top", then "left" -> 3 watermarks
  3. Apply them in the order "left", then "top" -> 2 watermarks

Expected behavior

Combine the styles and display 3 watermarks (module instance names are distinct)

Logfile | Screenshot | Screencast

First "top", then "left":
top-then-left

First "left", then "top":
left-then-top

left watermarks.dtstyle.txt
top watermarks.dtstyle.txt

The "left" style:

        <plugin>
            <num>9</num>
            <module>6</module>
            <operation>watermark</operation>
            <!-- ... -->
            <multi_priority>1</multi_priority>
            <multi_name>top left</multi_name>
            <multi_name_hand_edited>1</multi_name_hand_edited>
        </plugin>
        <plugin>
            <num>8</num>
            <module>6</module>
            <operation>watermark</operation>
            <!-- ... -->
            <multi_priority>0</multi_priority>
            <multi_name>bottom left</multi_name>
            <multi_name_hand_edited>1</multi_name_hand_edited>
        </plugin>

The "top" style

        <plugin>
            <num>10</num>
            <module>6</module>
            <operation>watermark</operation>
            <!-- ... -->
            <multi_priority>1</multi_priority>
            <multi_name>top right</multi_name>
            <multi_name_hand_edited>1</multi_name_hand_edited>
        </plugin>
        <plugin>
            <num>9</num>
            <module>6</module>
            <operation>watermark</operation>
            <!-- ... -->
            <multi_priority>0</multi_priority>
            <multi_name>top left</multi_name>
            <multi_name_hand_edited>1</multi_name_hand_edited>
        </plugin>

Commit

No response

Where did you obtain darktable from?

self compiled

darktable version

4.5.0+1391~g0a39901aa5-dirty (because of the tone-eq experiment from #15743 (comment))

What OS are you using?

Linux

What is the version of your OS?

Ubuntu 23.10

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@TurboGit TurboGit added priority: medium core features are degraded in a way that is still mostly usable, software stutters reproduce: confirmed a way to make the bug re-appear 99% of times has been found difficulty: hard big changes across different parts of the code base bug: pending someone needs to start working on that labels Dec 2, 2023
@TurboGit TurboGit self-assigned this Dec 2, 2023
TurboGit added a commit to TurboGit/darktable that referenced this issue Dec 2, 2023
This is either the one from the module we replace or the new
multi-priority we got when duplicating the base module.

Fixes darktable-org#15806.
@TurboGit TurboGit added this to the 4.6 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that difficulty: hard big changes across different parts of the code base priority: medium core features are degraded in a way that is still mostly usable, software stutters reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants