Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collection sources with grouping #5478

Closed
garrett opened this issue Jun 15, 2020 · 11 comments
Closed

Improve collection sources with grouping #5478

garrett opened this issue Jun 15, 2020 · 11 comments
Assignees
Labels
Milestone

Comments

@garrett
Copy link

garrett commented Jun 15, 2020

Is your feature request related to a problem? Please describe.

It's quite difficult to collect images due to the extremely long list of sources in the lighttable's collect module, especially when the one I use most, "tag" feels like it's arbitrarily placed way down the list in the dropdown.

Describe the solution you'd like

Within the past release version or two (I don't remember exactly when), blend modes were grouped and organized. It would be wonderful if the collect module's source dropdown were also grouped and organized.

Additional context

Here's what the collect menu currently looks like:
collect

Here's the blend mode dropdown from the darkroom, serving as an inspiration of what it could be like:
Screenshot from 2020-06-15 15-36-02

@garrett
Copy link
Author

garrett commented Jun 15, 2020

I'd suggest something like this as a starting point:


files

  • film roll
  • folders
  • filename

metadata

  • tag
  • title
  • description
  • creator
  • publisher
  • rights
  • notes
  • color label
  • geotagging

time

  • date taken
  • datetime taken
  • import timestamp
  • change timestamp
  • export timestamp
  • print timestamp

capture details

  • camera
  • lens
  • aperture
  • exposure
  • focal length
  • iso
  • aspect ratio

darktable

  • version name
  • grouping
  • local copy
  • history
  • module
  • module order

@garrett
Copy link
Author

garrett commented Jun 15, 2020

The suggestion above is a quick attempt, where I tried to group items so they're easier to find. They're mainly in the order that they're most likely to be commonly used.

Base could be called something else, but it's basically the typical types of info that someone uses to find images. Tag is included here as it's extremely common to use tags to find images. (Alternatively, it could be at the top of the metadata group and the metadata group could be reodered to be before or after time, I suppose. That would still be better than what we currently have)

Time is self-explanatory.

Technical is a bunch of camera-assigned metadata referring to the hardware (camera + lens) and how it is used.

Metadata is the metadata that someone actively adds to the images when they're in darktable.

The darktable group is darktable-specific info at the bottom (plus filename, which is kind of an implementation detail in the way darktable is used).

@Nilvus
Copy link
Contributor

Nilvus commented Jun 15, 2020

I do not check carefully your suggestion list but I agree that would be good to have groups now, just as masks. As you say, that will help finding a filter more quickly now the list is quite long.

@TurboGit TurboGit added this to the 3.4 milestone Jun 15, 2020
@TurboGit TurboGit added the feature: enhancement current features to improve label Jun 15, 2020
@TurboGit
Copy link
Member

I fully agree !

@Egocentrix
Copy link

I really like this idea! Three remarks/nitpicking:

  • 'tag' is a metadata field
  • I'm not sure I would call 'file name' a darktable thing. I would put it with 'folder' and 'film roll'. Maybe 'File' would be a good category name for that?
  • In the Pixls-thread it was mentioned that 'technical' could maybe be called 'capture details' or 'camera settings'

@garrett
Copy link
Author

garrett commented Jun 16, 2020

Yeah, it does need some polishing. One of the goals was to try to get tag up near the top — it's a common way to select images (even if it's added metadata). Same for folders and film rolls.

I'm happy with any grouping that makes logical sense and prioritizes the ways most people start collecting images. In my case, it's by tag (as I have tagged my two decades work of photos extensively), but I know a lot of people don't tag as much as I do and instead use dates, "film rolls", or folders (usually sorted by dates and/or "film rolls" anyway). And even if we primarily use one of those, we're often enough using one of those other main methods of narrowing down images anyway.

I've revised my comment above with the grouping, taking @TurboGit's and @Egocentrix's comments into account.

@Nilvus
Copy link
Contributor

Nilvus commented Jun 16, 2020

Much better order and categories now. Personally, I would make capture details before time but that just personal, probably many others would see the opposite, so it's good as it is.

I hope that the implementation would allow to also adjust with CSS to make categories titles as bold. It's unfortunately not possible to do for masks as it is specific bauhaus widget who don't allow that. Having titles visually different help to see categories and visually go quickly to good part.

@Egocentrix
Copy link

One of the goals was to try to get tag up near the top — it's a common way to select images (even if it's added metadata). Same for folders and film rolls.

Personally I wouldn't mind not having tag at the top, even though I use it often. I have a preset set up for the collect module, that selects by file name, tag and color label (in 'narrow down' mode, so I can use either of them).

@github-actions
Copy link

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@TurboGit
Copy link
Member

TurboGit commented Sep 5, 2020

I'll try to work on that.

TurboGit added a commit to TurboGit/darktable that referenced this issue Sep 5, 2020
TurboGit added a commit to TurboGit/darktable that referenced this issue Sep 5, 2020
TurboGit added a commit to TurboGit/darktable that referenced this issue Sep 5, 2020
TurboGit added a commit to TurboGit/darktable that referenced this issue Sep 6, 2020
TurboGit added a commit to TurboGit/darktable that referenced this issue Sep 6, 2020
@TurboGit
Copy link
Member

TurboGit commented Sep 7, 2020

Implemented and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants