Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows translation bundling alternative #10807

Merged
merged 1 commit into from Feb 23, 2022

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Jan 5, 2022

Addresses #9433 in a somewhat different way: bundles only the explicitly required translation catalogs for any locale available, thus reducing the installer size (this is the case already for macOS).

Also switch to canonical "iso_639-2" for all installers.

@TurboGit TurboGit added this to the 4.0 milestone Jan 5, 2022
@TurboGit TurboGit added scope: codebase making darktable source code easier to manage scope: translation / strings make darktable international scope: windows support windows related issues and PR labels Jan 5, 2022
@TurboGit
Copy link
Member

TurboGit commented Jan 5, 2022

I'll let @wpferguson approve this, too much Windows oriented for my skills.

@parafin
Copy link
Member

parafin commented Jan 6, 2022

Out of the interest - what is the difference between iso_639 and iso_639-2?

@kmilos
Copy link
Contributor Author

kmilos commented Jan 6, 2022

No difference, just that "iso_639" is obsoleted and is currently a symlink/copy to support legacy apps. I don't consider dt to be a legacy app ;)

The gettext domains have been renamed to better match the actual ISO number:

ISO 639-2: Renamed from iso_639 to iso_639-2
ISO 639-3: Renamed from iso_639_3 to iso_639-3
ISO 639-5: Renamed from iso_639_5 to iso_639-5
ISO 3166-1: Renamed from iso_3166 to iso_3166-1
ISO 3166-2: Renamed from iso_3166_2 to iso_3166-2

All previously used gettext domains are linked to the new domain names, so that this transition should be smooth for programs using those domain names.

@TurboGit
Copy link
Member

@kmilos : There is conflicts to be resolved here. TIA.

@kmilos
Copy link
Contributor Author

kmilos commented Feb 21, 2022

Done, ready for review @wpferguson @TurboGit

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move on, this seems ok to me. That's the kind of change that need field testing, so merging now. Thanks.

@TurboGit TurboGit merged commit bc6bd40 into darktable-org:master Feb 23, 2022
@kmilos
Copy link
Contributor Author

kmilos commented Feb 23, 2022

Merci

@kmilos kmilos deleted the install_trans branch February 23, 2022 08:31
@kmilos
Copy link
Contributor Author

kmilos commented Feb 25, 2022

The installer size went down by 15MB as result, thanks. 😉

@TurboGit
Copy link
Member

Well thanks to you for this achievement !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: codebase making darktable source code easier to manage scope: translation / strings make darktable international scope: windows support windows related issues and PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants