Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't map default rating shortcuts to numeric keypad #12351

Merged
merged 2 commits into from Aug 27, 2022

Conversation

dterrahe
Copy link
Member

Under Windows, inputng mapped default shortcuts for assigning ratings (0-5) to the numpad keys, which wasn't made explicit in the key name when pressing h, making it seem like they simply did not work. This may have been due to recent gtk/gdk changes "fixing" keyboard handling under Win32 or this may always have been the case.

Now, try to avoid numpad keys and if used, add " (numpad)" (like gtk does for some, but not all, numpad keys) so the distinction is visible.

Before inputng both sets of numeric keys used to be treated identically, but that meant fewer separate keys were available for shortcuts. If a user still wants "1" and "1 (keypad)" to do the same thing, it is fairly simple to set up the duplicate mappings:

  1. switch to key mapping mode by clicking the "define shortcuts" button (left of preferences)
  2. click on a star rating (this will open the shortcuts dialog with the "rating" action selected)
  3. in the bottom half of the screen, double click on the existing shortcut for the "0" key
  4. press the "0" key on the numpad. This should add a second shortcut for views/thumbtable/rating, zero to the list.
  5. go to step 3 for each of 1, 2, 3, 4, 5

fixes aurelienpierreeng#8

image

@dterrahe dterrahe added bugfix pull request fixing a bug difficulty: average some changes across different parts of the code base scope: UI user interface and interactions scope: OS support making darktable work on particular operating systems labels Aug 23, 2022
@TurboGit TurboGit added this to the 4.0.1 milestone Aug 24, 2022
src/gui/accelerators.c Outdated Show resolved Hide resolved
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@dterrahe
Copy link
Member Author

@dterrahe dterrahe deleted the fix_default_num_sc branch February 4, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug difficulty: average some changes across different parts of the code base scope: OS support making darktable work on particular operating systems scope: UI user interface and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stars rating keyboard shortcut not functioning
2 participants