don't map default rating shortcuts to numeric keypad #12351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Windows, inputng mapped default shortcuts for assigning ratings (0-5) to the numpad keys, which wasn't made explicit in the key name when pressing h, making it seem like they simply did not work. This may have been due to recent gtk/gdk changes "fixing" keyboard handling under Win32 or this may always have been the case.
Now, try to avoid numpad keys and if used, add " (numpad)" (like gtk does for some, but not all, numpad keys) so the distinction is visible.
Before inputng both sets of numeric keys used to be treated identically, but that meant fewer separate keys were available for shortcuts. If a user still wants "1" and "1 (keypad)" to do the same thing, it is fairly simple to set up the duplicate mappings:
fixes aurelienpierreeng#8