Sync XMPs after tag attach/detach via Lua API. #1384
Conversation
|
Very good description of the problem. |
Forget the header
| } while((list_iter = g_list_next(list_iter)) != NULL); | ||
| } | ||
| g_list_free(g_list_first(tagged_images)); | ||
|
|
There was a problem hiding this comment.
why this chunk of code ? what are you fixing ?
There was a problem hiding this comment.
The code is from src/libs/tagging.c, delete_button_clicked. dt_tag_remove only removes the tag from the database. The XMPs are not updated. The code collects all images with the tag before the tag is removed and syncs the XMPs after the tag is removed.
|
This looks correct but I don't have time to completely check and we are deep in RC territory. that would be worth adding, though. no API change, strictly a bugfix |
In fact, we already had the last RC before the release |
|
ok, first stable update it is, then... that is not a release blocker |
|
@boucman feel free to merge this one if you think it makes sense. |
When tags are attached/detached via Lua API, only the database entries are updated. The XMP files are not updated. This should fix it.