Added default.nix for build/dev environment on NixOS #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer that file to be in |
|
I can put it there, but is there a better place, given that this has nothing to do with packaging darktable on NixOS (nixpkgs already handles that), but rather is about creating the dev environment there? |
LebedevRI
reviewed
Apr 21, 2017
packaging/nix/default.nix
Outdated
|
|
||
| src = pkgs.lib.cleanSource ./.; | ||
|
|
||
| buildInputs = with pkgs; with xorg; with gnome2; |
There was a problem hiding this comment.
are you sure about these deps? e.g. libgnome_keyring is dead. libglade, SDL are not deps.
and libpthreadstubs looks strange, is it not handled by std library?
There was a problem hiding this comment.
I took these from the Nixpkgs derivation, which I didn't write in the first place. However, it seems you're right, as I was able to remove all the ones you said and the build appeared fine to me.
Building should be a matter of: git submodule init git submodule update nix-shell packaging/nix ./build.sh --prefix ./install --build-dir ../darktable-build then following the final command from build.sh, cmake --build "../darktable-build" --target install -- -j4 or whatever.
7 tasks
Hodapp87
added a commit
to Hodapp87/nixpkgs
that referenced
this pull request
May 1, 2017
Based on what LebedevRI told me on IRC and in darktable-org/darktable#1474
jtojnar
pushed a commit
to Hodapp87/nixpkgs
that referenced
this pull request
Feb 9, 2018
Based on what LebedevRI told me on IRC and in darktable-org/darktable#1474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully make it easy to create a build/development environment on NixOS right from a checked-out darktable repo (if a newer version than available in the nixpkgs repos is desired). I'd like to add some short instructions to https://redmine.darktable.org/projects/darktable/wiki/Building_darktable_20 for this, probably some variant of the below.
Building is a matter of:
Or,
nix-buildwill build the packaged NixOS binaries, andnix-env -f . -i ".*"will build and install.