Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on startup when debug output enabled #15397

Conversation

victoryforce
Copy link
Collaborator

No description provided.

@wpferguson
Copy link
Member

Tested on windows and still crashes. On Linux no crashes with or without the change.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, strange to see a dt_free_align() here! Thanks!

@TurboGit TurboGit merged commit 13c3c99 into darktable-org:master Oct 9, 2023
6 checks passed
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes labels Oct 9, 2023
@TurboGit TurboGit added this to the 4.6 milestone Oct 9, 2023
@victoryforce victoryforce deleted the fix-crash-with-debug-printing-enabled branch October 9, 2023 20:26
@wpferguson
Copy link
Member

Further testing revealed that this does indeed fix the crash on windows. I also had a corrupt configuration directory, so once I got rid of that I could do some accurate testing.

@wpferguson
Copy link
Member

Thanks @victoryforce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants