fix scripts_installer handling user names with spaces on windows #15437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpferguson
added
bugfix
|
@wpferguson : Can you rebase on current master? The GitHub-CI issue should be fixed there. TIA. |
is happening when the scripts_installer doesn't work.
Added a lua preference to turn the debugging messages
on and off.
installer is visible.
windows by...
adding the string sanitize functions from the lua scripts
string library to handle spaces in argument strings.
wrapping the os.execute() command with an os_execute()
function that surrounds the command in quotes before sending
to os.execute() if we are on windows. This is necessary if
there is more than one quoted string in the command.
|
@TurboGit how do I do that? I did |
|
You need to force push with option |
|
Thanks. That's what I thought but I didn't want to break anything. |
wpferguson
force-pushed
the
scripts_installer_updates
branch
from
3ec4afe
to
eb64778
Compare
|
Hi, FYI it's been reported the same issue on Mac when the username has a space in it. A workaround might be to replace on line 115 of luarc: |
|
Please open an issue at https://github.com/darktable-org/lua-scripts/issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install the lua scripts on windows when the username has a space in it.
Just for reference the proper way to quote argument strings with spaces for windows is
""\Program Files\darktable\bin\darktable" "\Users\A User\Pictures\img1234.cr2""