Fix details mask on low opencl memory #16003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the design of the details threshold mask we precalculate the scharr mask in demosaic module but we do **not** support doing that in tiling mode. In darktable-org#15999 and related reports in pixls and on github we ran into problems because of tiling the generated scharr mask did not cover the full roi of demosaic but just a part of it, this lead to crashes. Due to the way we commit parameters while preparing the pipeline we have to make sure about no tiling while committing params and also make sure in process and the cl variant.
jenshannoschwalm
added
bugfix
|
When I tested the issue, I noticed that it also happens on CPU path. I had to use the notebook resources setting and disable opencl. |
|
I just tested it and it works in both CPU and openCL path. Thanks. |
Right. |
|
Merged in master and 4.6.x branch. |
|
Release note would be: Fix crashes related to details mask if running on low OpenCL or system memory |
This was referenced Feb 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the design of the details threshold mask we precalculate the scharr mask in demosaic module but we do not support doing that in tiling mode.
In #15999 and related reports in pixls and on github we ran into problems because of tiling the generated scharr mask did not cover the full roi of demosaic but just a tile of it, this lead to crashes.
Due to the way we commit parameters while preparing the pipeline we have to make sure about no tiling while committing params and also make sure in process and the cl variant.
Fixes #15999
For 4.6 and 4.8