Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image information]:More exif info fields #16461

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Mar 14, 2024

This PR adds a few more EXIF fields to the image info module:

  • white balance
  • flash
  • exposure program
  • metering mode

Bildschirmfoto 2024-03-14 um 18 40 53

This is filled automatically for newly imported images. For existing images, a refresh EXIF is required

Bildschirmfoto 2024-03-14 um 18 42 15

closes #16418

@TurboGit TurboGit added this to the 4.8 milestone Mar 15, 2024
@TurboGit TurboGit added feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending labels Mar 15, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not upgrade on my side:

     1,6624 [init] can't rename images
     1,6624 [init]   error in view v_images: no such table: main.images
     1,6629 [init] database `library.db' couldn't be upgraded from version 50 to 51. aborting
     1,6635 ERROR : cannot open database

I think that as for version 41 -> 42 you need to remove v_images and create it back.

@TurboGit
Copy link
Member

You may also want to squash some commits to have a clean history (last commit here could be merged into the database migration commit).

  - white balance
  - flash
  - exposure program
  - metering mode
  - white balance
  - flash
  - exposure program
  - metering mode

fix SQL error

recreate view v_images
@zisoft
Copy link
Collaborator Author

zisoft commented Mar 15, 2024

Fixed the v_images issue, squashed and rebased.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now. Thanks!

Need a release note entry.

@TurboGit TurboGit merged commit 248ea0a into darktable-org:master Mar 15, 2024
6 checks passed
@zisoft
Copy link
Collaborator Author

zisoft commented Mar 15, 2024

For the release notes:

Added a few more EXIF fields to the image information module: White balance, exposure program, flash and metering mode.
These get filled automatically for new imports. For existing photos please perform a "refresh EXIF" on the selected images.

@zisoft zisoft deleted the more-exif-info-fields branch March 15, 2024 19:03
@TurboGit
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't scope: DAM managing files, collections, archiving, metadata, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image information: show white balance and flash fired or not fired info from the camera
2 participants