[GUI] Some fixes in CE tooltips #16474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term is spelled
chromaticity, notchromacity. This is obviously a typo and the correction needs no explanation. As for removing one punctuation point in another tooltip, it's worth giving a rationale.Now, when darktable tooltips have phrases that are formatted as list items (lines with dashes at the beginning), we use one of two styles. In one of them, a punctuation mark (comma) is placed at the end of each line (list element) and the entire text ends with a period. In another style, no punctuation mark is placed at the end of such lines. We can discuss whether to make one style mandatory, but in this case, no style was followed. If we do not put punctuation in one of the list items, then we do not need to put a period in the last item.