Added contextual help links #1656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will now stop waiting your approval for the changes done till now. |
houz
reviewed
Feb 27, 2018
src/libs/collect.c
Outdated
| @@ -1391,17 +1392,20 @@ static void combo_changed(GtkComboBox *combo, dt_lib_collect_rule_t *d) | |||
| || property == DT_COLLECTION_PROP_ISO) | |||
| { | |||
| gtk_widget_set_tooltip_text(d->text, _("type your query, use <, <=, >, >=, <>, =, [;] as operators")); | |||
| dt_gui_add_help_link(d->text, "collect_images.html#collect_images_usage"); | |||
There was a problem hiding this comment.
You don't need to set the help text in this function, just do it once in gui_init() when the widgets are created.
src/libs/colorpicker.c
Outdated
| @@ -142,6 +142,7 @@ static void _update_picker_output(dt_lib_module_t *self) | |||
| darktable.gui->reset = 1; | |||
| gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(data->picker_button), | |||
| module->request_color_pick != DT_REQUEST_COLORPICK_OFF); | |||
| dt_gui_add_help_link(data->picker_button, "global_color_picker.html#global_color_picker"); | |||
There was a problem hiding this comment.
Again, only set the help text once when creating a widget.
|
This pull request should be closed. The commits have been integrated in pull request #1774, and have been integrated in master. |
|
Indeed, thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.