masks/circle: save sanitized values to config file #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ever the darktablerc files gets incorrect values, like negative ones, the code was applying a sanitization, but not saving the sanitized values. As a result, the next call to dt_conf_get_float was restoring the un-sanitized value. Fix this by calling dt_conf_set_float to save the sanitized values, like we did in liquify in 951bd8c (liquify: fix mouse wheel on first launch, 2018-11-28). This should not be needed in principle, but makes dt a bit more robust to mis-configuration.
|
Sounds good! Thanks Matthieu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ever the darktablerc files gets incorrect values, like negative
ones, the code was applying a sanitization, but not saving the
sanitized values. As a result, the next call to dt_conf_get_float was
restoring the un-sanitized value.
Fix this by calling dt_conf_set_float to save the sanitized values,
like we did in liquify in 951bd8c (liquify: fix mouse wheel on first
launch, 2018-11-28).
This should not be needed in principle, but makes dt a bit more robust
to mis-configuration.