-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colorzones zoom - plus fix #2214
Conversation
14ba912
to
c9deaf9
Compare
c9deaf9
to
ec7b50a
Compare
Interesting... after this, the issue I described in #2167 is reversed: now a newly added node appears at the bottom of the graph instead of the top. |
@junkyardsparkle , it seems that we don't understand each other. There are two ways to add a node: -click and drag: the node is added at mouse position and then it follows the mouse have you found a 3rd way? |
I understand you, and I'm trying very hard to be understandable myself. The behavior I'm describing is with the first case you mention. When I click and drag, the node is not added at the mouse position, as you describe (and as I would expect). Peviously, it was being added at the top of the graph, and after this commit, it is now being added at the bottom. The x position is always correct. The ctrl+click behavior is also correct. By now it's clear to me that I'm seeing a different behavior than you and others. This could be due to some old cairo bug, I don't know. It has never been the case with the other modules which present a "curves" interface, though (including the old color zones). If more people test this and don't get "bitten", it may be too obscure to worry about... there probably aren't too many people still using Slackware 14.2 at this point. ;) I wasn't planning to mention it again, except that the behavior changed at this point, which may be a clue. |
If you're getting this by click+drag it won't be easy to fix, it is working fine for me. |
I'm looking around too, but I don't have a good grasp of gtk. Probably the best thing at this point is to get as many people as possible to test the module. If it's broken for anyone else, we can "triangulate". |
Fix colorzone histogram zoom when histogram is not in linear mode.