Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorzones zoom - plus fix #2214

Merged
merged 3 commits into from
Mar 15, 2019
Merged

colorzones zoom - plus fix #2214

merged 3 commits into from
Mar 15, 2019

Conversation

TurboGit
Copy link
Member

Fix colorzone histogram zoom when histogram is not in linear mode.

@TurboGit TurboGit added bugfix pull request fixing a bug feature: enhancement current features to improve labels Mar 15, 2019
@TurboGit TurboGit added this to the 2.8 milestone Mar 15, 2019
@TurboGit TurboGit self-assigned this Mar 15, 2019
@TurboGit TurboGit force-pushed the colorzones-zoom branch 2 times, most recently from 14ba912 to c9deaf9 Compare March 15, 2019 09:30
@junkyardsparkle
Copy link
Contributor

Interesting... after this, the issue I described in #2167 is reversed: now a newly added node appears at the bottom of the graph instead of the top.

@edgardoh
Copy link
Contributor

@junkyardsparkle , it seems that we don't understand each other.

There are two ways to add a node:

-click and drag: the node is added at mouse position and then it follows the mouse
-cntrl+click: the node is added at x=mouse position, y=curve position

have you found a 3rd way?

@junkyardsparkle
Copy link
Contributor

I understand you, and I'm trying very hard to be understandable myself. The behavior I'm describing is with the first case you mention. When I click and drag, the node is not added at the mouse position, as you describe (and as I would expect). Peviously, it was being added at the top of the graph, and after this commit, it is now being added at the bottom. The x position is always correct. The ctrl+click behavior is also correct.

By now it's clear to me that I'm seeing a different behavior than you and others. This could be due to some old cairo bug, I don't know. It has never been the case with the other modules which present a "curves" interface, though (including the old color zones). If more people test this and don't get "bitten", it may be too obscure to worry about... there probably aren't too many people still using Slackware 14.2 at this point. ;) I wasn't planning to mention it again, except that the behavior changed at this point, which may be a clue.

@edgardoh
Copy link
Contributor

If you're getting this by click+drag it won't be easy to fix, it is working fine for me.
I have an open PR #2217 with some fixes for the color zone, if you can build it then try that, if still not working let me know and we can work together to try to debug it.

@junkyardsparkle
Copy link
Contributor

I'm looking around too, but I don't have a good grasp of gtk. Probably the best thing at this point is to get as many people as possible to test the module. If it's broken for anyone else, we can "triangulate".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug feature: enhancement current features to improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants