-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct some CSS issues remaining on UI #2586
Conversation
@Nilvus , looks the same to me, something else than building it that I should do? |
That's not really looks the same to me, but that's not the same as right panel. I've made lot of tests without success. What I propose to you at first yesterday break other dialog box. But I've just had another idea that should much better. See new commit. |
Sorry for two last commit. I forget something and didn't understand on resolving that I was just merging master css... I will stop for tonight. |
Issue #2481 now corrected. |
@edgardoh : could you test last updates of css. What do you think about these changes, especially prefs entries (and filter collection one) as it's related to your issue. |
@Nilvus : sounds like you are correct and I'm wrong: https://www.w3.org/Style/Examples/007/units.en.html pt should not be used for screen and px should be preferred. |
By now, I hope this last commit will end this PR. I have just improve contrast with revert back grey_55 to default css color. That make a better contrast especially on filmstrip (difficult to make it better without breaking things). I also clean grey css as it have redundant lines with darktable.css related theme. A comment needs to be more precise so I updated it. |
@TurboGit : anyway I also found that 1pt=1.33px, so I can't change just the unit. For example, I have replaced font-size of blending tabs from 8pt to 8 px and see that line becoming too small. But changing it to 0.8em (or 10px or 11px, as 8pt = 10.64px) make it better. |
As I hope UI is better now, see screenshots of new main updates to help review : Filter collection entry and arrow dropdown More condensed darkroom history New live sample (main work by @TurboGit on another commit, just improve text lisibility) |
@Nilvus , much better. Still the controls (text entry, check box) could be smaller (in height), also the space between controls. But if can't be done I can live with it. |
You will have to forgot having a smaller height as the window is a grid, I could only reduce height with margin and padding already to 0. And negative values are not recognized. So for that, it's not possible without a Gtk rework... For space, it's possible by reducing margin from this part :
If I reduce from 5px to 3px, see new spacing (keep quite aerate would be better so I'm not on to reduce spacing more) : |
Finally, prefs window is probably better with reducing space as last screen capture. So committed with a darktable-elegant code cleanup (many lines redundant from darktable default css and some lines forgotten and not needed, ie live-sample-data better with darktable default settings). I also changed font-weight from 400 to normal to have the same setting (400=normal on css) on css. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! Thanks.
A new set of CSS improvements. This PR should resolve some remaining issues :
I also reduce size on some dropdown button arrows, especially on filter collection (I also reduce height size on entry item near this dropdown) and display dropdown on filmic that was way too big.
@aurelienpierre : could you see if it's ok for you as it change some of your choices ?
Before merging that, please test as much as you can. I made lot of reviews tests and compare with actual themes what change and if this new css breaks other part. I don't find anything on lot of modules I test, even on map and print parts (I don't test capture part as I don't have a camera compatible).
As I change lot of things, I want to be sure that nothing is broken on the UI.