Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lut3d - improve live gmic version detection #4072

Merged
merged 1 commit into from
Jan 9, 2020
Merged

lut3d - improve live gmic version detection #4072

merged 1 commit into from
Jan 9, 2020

Conversation

phweyland
Copy link
Contributor

Try to improve gmic version detection and possibly solve the issue #4067 .
Two main points

  • consider versions with 4 digits instead of 3
  • check both the build time version and the run time version.

@TurboGit
Copy link
Member

TurboGit commented Jan 9, 2020

I'm not in a position to check that but it looks ok so I'll merge. Thanks!

@TurboGit TurboGit self-requested a review January 9, 2020 18:31
@TurboGit TurboGit self-assigned this Jan 9, 2020
@TurboGit TurboGit added the feature: enhancement current features to improve label Jan 9, 2020
@TurboGit TurboGit added this to the 3.0.1 milestone Jan 9, 2020
@TurboGit TurboGit merged commit f4689af into darktable-org:master Jan 9, 2020
@phweyland
Copy link
Contributor Author

Thanks
I've made another small improvement (avoid to call at each init the run time library to check the version), but I will wait if we don't have another fix to do on the current issue.

@phweyland phweyland deleted the lut3d-fix branch January 9, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit Awaiting requested review from TurboGit

Assignees

@TurboGit TurboGit

Labels
feature: enhancement current features to improve
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phweyland @TurboGit