Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix module order - synch with history at import time #4329

Merged
merged 1 commit into from Feb 20, 2020

Conversation

phweyland
Copy link
Contributor

Related to #4313

@phweyland
Copy link
Contributor Author

phweyland commented Feb 20, 2020

Should be better after lightroom import.

This fix helps getting more synchronized info from collection history / module order. However not sure that is enough.

@TurboGit
Copy link
Member

One question though. Adding this here now means that all imported pictures have an iop-order list so we cannot distinguish the non yet edited pictures. Right? Won't that be a nuisance for your altered work? Or maybe I'm confused... (little time at the moment to review seriously).

@TurboGit TurboGit self-requested a review February 20, 2020 14:31
@TurboGit TurboGit added this to the 3.2 milestone Feb 20, 2020
@phweyland
Copy link
Contributor Author

Adding this here now means that all imported pictures have an iop-order list so we cannot distinguish the non yet edited pictures. Right?

In fact that doesn't change anything on history side, just on module_order side.
The collection / history - altered / not altered relies only on history.

But this PR makes collection / module order match with collection / history one (so far :)). Wants to answer your concern merging collection / history & module order.

@phweyland
Copy link
Contributor Author

Won't that be a nuisance for your altered work?

I don't think so. I'm still trying to find a firm ground to strengthen the altered / not altered status. This is part of it.

@TurboGit
Copy link
Member

Ok, let's go with that then. Thanks.

@TurboGit TurboGit merged commit 119c7fa into darktable-org:master Feb 20, 2020
@phweyland phweyland deleted the modorder-fix branch February 20, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants