Exposure IOP: Deflicker (port from Magic Lantern) #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quick note (this was discussed on IRC) JPG become completely black when deflicker is enabled. This needs to be fixed before merge
investigation is in progress |
* master: (66 commits) Get rid of most .h files in iop/ masks: better prevention of memory fragmentation calculator: do not use integer variable in read_number() to store intermediate values noise profile: panasonic dmc-lx7 by deryk lister lua: fix post-image-import not working for imgid >255 sync darktable-9999.ebuild cmake: Drop obsolete EXPERIMENTAL and LEGACY flags [l10n] Swedish update of .desktop strings Italian translation updated Updated Dutch translation tiff output: tentatively fix compilation with libtiff 3.9 which lacks tmsize_t Show pixelpipe flow info when -d perf Updated Danish translation tiff output: several fixes Update French translation. _Keywords got dropped by mistake, restore it Make data/darktable.desktop translatable along with all other things that need translation. To translate, translators don't need to do anything more than they have done so far, it just beomes a few more strings to translate. Add German keywords to .desktop file Add italian keywords in .desktop tiff output: set sample format for 8bit and 16bit too ... Conflicts: src/iop/exposure.h
Conflicts: src/gui/accelerators.c src/libs/masks.c
|
ok, we are getting there, there are still a couple of weird details I found out, though...
|
…icker * upstream/master: Add iop introspection. WARNING: we require perl now masks: fix another potential memory leak Do not take sizeof of a pointer masks: fix huge memory leak Revert "Fix wrong memcpy" imageio_gm: clearly indicate when GraphicsMagick is being used (cherry picked from commit 3ba03fe) imageio_tiff: remove leftover assert (cherry picked from commit ea8a348) Fix whitespace fix a possible crash detected by coverity For static arrays, use sizeof(array), not magic numbers Use glib str functions Fix wrong memcpy Don't switch group if module activated via hotkey is already visible Conflicts: src/iop/exposure.c
|
First issue is fixed. |
|
note that the "auto" button, which is supposed to work more or less the same way doesn't have the problem. maybe check in what way they differ ? |
…called and almost circular depency will arise
boucman
added a commit
that referenced
this pull request
Mar 5, 2014
Exposure IOP: Deflicker (port from Magic Lantern)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same functionality as in Post Deflicker module of Magic Lantern.
Note: though the algo is the same, computed EV might be slightly different from ML's (on same image and same settings)